Closed Bug 1319982 Opened 5 years ago Closed 5 years ago

move stop-gap Servo_GetStyleVariables definition to Servo

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(1 file)

Currently we implement Servo_GetStyleVariables in C++, since there's no equivalent Servo style struct for Variables.  If we move it to rust, then we can treat it like all the rest of the Servo_GetStyleXXX style struct accessor functions, and make it easier to not define it twice in a non-MOZ_STYLO build.
Comment on attachment 8813947 [details]
Bug 1319982 - Move Servo_GetStyleVariables definition to the Servo side.

https://reviewboard.mozilla.org/r/95244/#review95546
Attachment #8813947 - Flags: review?(manishearth) → review+
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6cd80e49535f
Move Servo_GetStyleVariables definition to the Servo side. r=manishearth
https://hg.mozilla.org/mozilla-central/rev/6cd80e49535f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.