1319995 - Set the substituting handler of the resources of "formautofill" in xpcshell tests

Status: RESOLVED FIXED

(Toolkit :: Form Manager, enhancement, P3)

Description

[Luke Chang [:lchang] (inactive)]

I just learnt that it might be a proper way to load addon resources in xpcshell tests.

Comment 1

[Luke Chang [:lchang] (inactive)]

Attachment: Bug 1319995 - Set the substituting handler of the resources of "formautofill" in xpcshell tests;

Review commit: https://reviewboard.mozilla.org/r/95262/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95262/

Comment 2

[Luke Chang [:lchang] (inactive)]

Hi Matt,

By changing to this we don't need to mock "defineLazyModuleGetter" (and even "Cu.import") in "head.js" anymore. I think it would be more intuitive and helpful for further tests' implementation. Could you take a look? Thanks.

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8813957 [details]
Bug 1319995 - Set the substituting handler of the resources of "formautofill" in xpcshell tests;

https://reviewboard.mozilla.org/r/95262/#review95572

r=me with the cleanup.

::: browser/extensions/formautofill/test/unit/head.js:21
(Diff revision 1)
> +// Register the resource path of formautofill
> +let resHandler = Services.io.getProtocolHandler("resource")
> +                            .QueryInterface(Ci.nsISubstitutingProtocolHandler);
> +let dataURI = NetUtil.newURI(do_get_file(".", true));
> +resHandler.setSubstitution("formautofill", dataURI);

Cool. It seems like we should also have a registerCleanup… in head.js to revert this at the end of each test so it doesn't leak into non-autofill tests.
"A null baseURI removes the specified substitution."

Comment 4

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8813957 [details]
Bug 1319995 - Set the substituting handler of the resources of "formautofill" in xpcshell tests;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/95262/diff/1-2/

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8813957 [details]
Bug 1319995 - Set the substituting handler of the resources of "formautofill" in xpcshell tests;

https://reviewboard.mozilla.org/r/95262/#review95572

> Cool. It seems like we should also have a registerCleanup… in head.js to revert this at the end of each test so it doesn't leak into non-autofill tests.
> "A null baseURI removes the specified substitution."

Thanks for pointing it out. I end up added the clean-up code in tail.js so we can avoid forgetting to do that in each test.

Comment 6

[Luke Chang [:lchang] (inactive)]

Tests passed.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82018512953d
Set the substituting handler of the resources of "formautofill" in xpcshell tests; r=MattN

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/82018512953d