1320006 - Android local build failure after bug 1319345

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[James Cheng[:JamesCheng]]

Attachment: build error by bug 1319351

I don't know why this may happen on my machine only... I ask other people to test but they don't meet this error.

The attachment is the log by "mach build -v"

I can build success without the patch by bug 1319351.

Comment 1

[Mike Hommey [:glandium]]

As said on irc, this can't be attributed to bug 1319351, and considering the build log, bug 1319345 is the only plausible explanation.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1320006 - Shell-quote the flags used for file_generate commands.

Ideally, we'd shell-quote more arguments, but that would also require
different quoting for the make dependencies and the command line
arguments, so go for the immediate need.

Review commit: https://reviewboard.mozilla.org/r/95280/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95280/

Comment 3

[James Cheng[:JamesCheng]]

This patch works for me. 

Thanks.

I should do "git bisect" and clobber it every time I do "mach build"...

I didn't, so the git bisect result points to the wrong revision.

Comment 5

[Michael Shal [:mshal]]

Comment on attachment 8813978 [details]
Bug 1320006 - Shell-quote the flags used for file_generate commands.

https://reviewboard.mozilla.org/r/95280/#review95998

Comment 6

[Justin Wood (:Callek)]

This is busting `date` since today's merge from m-c (merges happen by me, on the same rev as the m-c nightly) -- so the earlier you can land this the better (so it can reach m-c in time for tomorrows nightly).

Thank You.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/758c23c92f08
Shell-quote the flags used for file_generate commands. r=mshal

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/758c23c92f08

Comment 10

[Paul Kerr [:pkerr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=af033d8ddb8e