Closed Bug 1320042 Opened 3 years ago Closed 3 years ago

Rename BytecodeEmitter::emitConditionallyExecuted{SOMETHING} to BytecodeEmitter::emit{SOMETHING}InBranch.

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

BytecodeEmitter::emitConditionallyExecuted{SOMETHING} name is too long and it often breaks stack comment.
Changed 2 methods:
  emitConditionallyExecutedTree -> emitTreeInBranch
  emitConditionallyExecutedDestructuringLHS -> emitDestructuringLHSInBranch
Attachment #8814040 - Flags: review?(shu)
Comment on attachment 8814040 [details] [diff] [review]
Rename BytecodeEmitter::emitConditionallyExecuted{SOMETHING} to BytecodeEmitter::emit{SOMETHING}InBranch.

Review of attachment 8814040 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great. Sorry for the delay!
Attachment #8814040 - Flags: review?(shu) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/78e008ce3a8c40c79f41567ede23e7de83d614dc
Bug 1320042 - Rename BytecodeEmitter::emitConditionallyExecuted{SOMETHING} to BytecodeEmitter::emit{SOMETHING}InBranch. r=shu
https://hg.mozilla.org/mozilla-central/rev/78e008ce3a8c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.