Rename BytecodeEmitter::emitConditionallyExecuted{SOMETHING} to BytecodeEmitter::emit{SOMETHING}InBranch.

RESOLVED FIXED in Firefox 53

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: arai, Assigned: arai)

Tracking

Trunk
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
BytecodeEmitter::emitConditionallyExecuted{SOMETHING} name is too long and it often breaks stack comment.
(Assignee)

Comment 1

2 years ago
Created attachment 8814040 [details] [diff] [review]
Rename BytecodeEmitter::emitConditionallyExecuted{SOMETHING} to BytecodeEmitter::emit{SOMETHING}InBranch.

Changed 2 methods:
  emitConditionallyExecutedTree -> emitTreeInBranch
  emitConditionallyExecutedDestructuringLHS -> emitDestructuringLHSInBranch
Attachment #8814040 - Flags: review?(shu)

Comment 2

2 years ago
Comment on attachment 8814040 [details] [diff] [review]
Rename BytecodeEmitter::emitConditionallyExecuted{SOMETHING} to BytecodeEmitter::emit{SOMETHING}InBranch.

Review of attachment 8814040 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great. Sorry for the delay!
Attachment #8814040 - Flags: review?(shu) → review+
(Assignee)

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/78e008ce3a8c40c79f41567ede23e7de83d614dc
Bug 1320042 - Rename BytecodeEmitter::emitConditionallyExecuted{SOMETHING} to BytecodeEmitter::emit{SOMETHING}InBranch. r=shu

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/78e008ce3a8c
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.