Closed Bug 1320053 Opened 3 years ago Closed 3 years ago

Something wrong with Edit as html wrapper (Inspector tab)

Categories

(DevTools :: Inspector, defect, P1)

52 Branch
defect

Tracking

(firefox50 unaffected, firefox51 unaffected, firefox52 fixed, firefox53 fixed)

RESOLVED FIXED
Firefox 53
Tracking Status
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: dehghani.m.c, Assigned: jdescottes)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image 1111.png
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20161124004020

Steps to reproduce:

In Inspector, right click on some node & select "Edit as HTML", the editing works fine, but the added wrapper is not.


Actual results:

Style of added wrapper for "Edit as HTML" is not good. (see the attached Screenshot)


Expected results:

Style of added wrapper for "Edit as HTML" must be good :)
Component: Untriaged → Developer Tools: Inspector
Confirmed. I'm looking for a regression range now.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Looks like the following bug has the changes which introduced the regression:
https://bugzilla.mozilla.org/show_bug.cgi?id=1292592
Inspector bug triage (filter on CLIMBING SHOES).
Priority: -- → P1
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
When loading the source editor in an iframe, the following stylesheet is included as a <style> tag in the document:

>  html, body { 
>    height: 100%; 
>  }
>
>  body {
>    margin: 0;
>    overflow: hidden; 
>  }
> 
>  .CodeMirror { 
>    width: 100%;
>    height: 100% !important;
>    line-height: 1.25 !important;
>  }

But when loaded in a local element the .CodeMirror element height is set by codemirror.css which forces height: 300px;
Comment on attachment 8814462 [details]
Bug 1320053 - set height 100% on .CodeMirror element;

https://reviewboard.mozilla.org/r/95694/#review95794

LGTM. Thank you for the fix!
Attachment #8814462 - Flags: review?(gl) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a105cf2d33a5
set height 100% on .CodeMirror element;r=gl
https://hg.mozilla.org/mozilla-central/rev/a105cf2d33a5
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Please request Aurora approval on this when you get a chance.
Flags: needinfo?(jdescottes)
I have reproduced this bug with Nightly 53.0a1 (2016-11-24) on Windows 8.1 , 64 Bit ! 

Build   ID    20161124030208
User Agent    Mozilla/5.0 (Windows NT 6.3; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0

This bug's fix is verified with latest Nightly !

Build   ID    20161204030210
User Agent    Mozilla/5.0 (Windows NT 6.3; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0

[bugday-20161130]
Comment on attachment 8814462 [details]
Bug 1320053 - set height 100% on .CodeMirror element;

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1292592
[User impact if declined]: Editing HTML in the inspector looks broken (see attachment).
[Is this code covered by automated tests?]:No, this was a styling regression
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]: No other changeset to uplift 
[Is the change risky?]: No
[Why is the change risky/not risky?]: Simple CSS fix
[String changes made/needed]: N/A
Flags: needinfo?(jdescottes)
Attachment #8814462 - Flags: approval-mozilla-aurora?
Comment on attachment 8814462 [details]
Bug 1320053 - set height 100% on .CodeMirror element;

devtools styling fix for aurora52
Attachment #8814462 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I have reproduced this bug with Nightly 53.0a1 (2016-11-24) (64-bit) on Windows 7, 64 Bit !

This bug's fix is verified with latest Aurora !

Build    ID  :      20161214004021
User  Agent  :      Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
[bugday-20161214]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.