Closed Bug 1320058 Opened 4 years ago Closed 3 years ago
Use or remove the chrome://browser/skin/preferences/save
File .png file on Windows
59 bytes, text/x-review-board-request
The test I'm working on in bug 1316187 flags the 2 following files as unreferenced on Windows: chrome://browser/skin/preferences/saveFile-XP.png chrome://browser/skin/preferences/saveFile.png I can't find any evidence of these files ever being used on Windows since they were introduced by bug 429282, but a file with the same name is used on Linux. So either application.png should be replaced with saveFile.png at http://searchfox.org/mozilla-central/rev/feef954874af9a18168e61a75629a9406b847c53/browser/themes/windows/preferences/applications.css#40 or we should just remove the two files from the Windows theme.
chrome://browser/skin/preferences/saveFile-XP.png no longer exists.
Comment on attachment 8873089 [details] Bug 1320058 - Use saveFile.png on windows for the save icon https://reviewboard.mozilla.org/r/144542/#review148418 It doesn't seem to make sense that browser/themes/windows/preferences/applications.css uses application.png as the Save icon. I think we should probably use saveFile.png there.
Attachment #8873089 - Flags: review?(dao+bmo) → review-
Comment on attachment 8873089 [details] Bug 1320058 - Use saveFile.png on windows for the save icon https://reviewboard.mozilla.org/r/144542/#review148780 Thanks!
Attachment #8873089 - Flags: review?(dao+bmo) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/ec18d62f02a9 Use saveFile.png on windows for the save icon r=dao
You need to log in before you can comment on or make changes to this bug.