Fix warnings caused by js/public/RootingAPI.h

NEW
Unassigned

Status

()

Core
JavaScript Engine
P3
normal
a year ago
2 months ago

People

(Reporter: jhao, Unassigned)

Tracking

({triage-deferred})

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

a year ago
See https://dxr.mozilla.org/mozilla-central/rev/34fce7c12173bdd6dda54c2ebf6d344252f1ac48/security/certverifier/CertVerifier.h#30

In order to include BasePrincipal.h in Certverifier.h, we have to suppress many warnings caused by js headers.

* RootingAPI.h(718): warning C4324: 'js::DispatchWrapper<T>': structure was padded due to alignment specifier with [ T=void * ]
* Value.h(448): warning C4365: 'return': conversion from 'const int32_t' to 'JS::Value::PayloadType', signed/unsigned mismatch
* warning C5031: #pragma warning(pop): likely mismatch, popping warning state pushed in different file

The last warning is due an unpopped pragma push at https://dxr.mozilla.org/mozilla-central/rev/34fce7c12173bdd6dda54c2ebf6d344252f1ac48/js/public/Vector.h#14

Comment 1

a year ago
Bug 1319831 addresses some of these warnings.
Depends on: 1319831
Summary: Fix warnings caused by js/Value.h, Vector.h, and RootingAPI.h → Fix warnings caused by js/public/RootingAPI.h
Keywords: triage-deferred
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.