Closed Bug 1320084 Opened 8 years ago Closed 7 years ago

Drop useless files from /devtools/

Categories

(DevTools :: General, defect, P1)

Product:
DevTools
Component:
General
Type:
defect

Tracking

(firefox53 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(3 files, 1 obsolete file)

Bug 1320084 - Remove unused devtools/client/themes/dom.css file.
58 bytes, text/x-review-board-request
Honza
: review+
Details
Bug 1320084 - Remove project editor test files from firefox package.
58 bytes, text/x-review-board-request
bgrins
: review+
Details
Bug 1320084 - Remove useless devtools JSM shims.
58 bytes, text/x-review-board-request
jryans
: review+
Details 
https://docs.google.com/spreadsheets/d/1lthM18DHQUy2Spn1IN8w-nXHjxU9ion91p996GoAH94/edit#gid=362236084
This document reports a bunch of files that seem to be unused.
Let's get rid of the one that are really useless, even by addons.
Comment on attachment 8814097 [details]
Bug 1320084 - Remove unused devtools/client/themes/dom.css file.

https://reviewboard.mozilla.org/r/95398/#review95544

LGTM, thanks!

R+

Honza
Attachment #8814097 - Flags: review?(odvarko) → review+
Comment on attachment 8814098 [details]
Bug 1320084 - Remove unused debugging-devices.svg file.

https://reviewboard.mozilla.org/r/95400/#review95556

I was planning on reusing the icon for Bug 1243329. Could we keep it around for the moment?
Attachment #8814098 - Flags: review?(jdescottes)
Attachment #8814098 - Attachment is obsolete: true
Simulator.jsm seems to be only used by Simulator 1.2 addon.
I removed resource:///modules/devtools/client/framework/gDevTools.jsm shim as it is still used by various addons but all of them have compatiblity code which uses resource:///modules/devtools/gDevTools.jsm
And resource://gre/modules/devtools/shared/Console.jsm doesn't seem to be used only by adbhelper 0.9.0:
  https://dxr.mozilla.org/addons/source/addons/464386/install.rdf
Comment on attachment 8814200 [details]
Bug 1320084 - Remove useless devtools JSM shims.

https://reviewboard.mozilla.org/r/95456/#review96120

Your analysis looks reasonable to me, thanks for the cleanup!
Attachment #8814200 - Flags: review?(jryans) → review+
Comment on attachment 8814099 [details]
Bug 1320084 - Remove project editor test files from firefox package.

https://reviewboard.mozilla.org/r/95402/#review96168

projecteditor-loader.xul and projecteditor-loader.js were previously used to be able to develop the project editor in a tab.  I don't think they are needed anymore, though so feel free to go ahead with it
Attachment #8814099 - Flags: review?(bgrinstead) → review+
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Priority: -- → P1
mozreview fails landing these patches, opened bug 1321548.
Depends on: 1321548
https://hg.mozilla.org/mozilla-central/rev/f9f9d3744d49
https://hg.mozilla.org/mozilla-central/rev/b7495abfbb10
https://hg.mozilla.org/mozilla-central/rev/769f1efe908d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: