1320096 - [Regression] Crash when deleting a login after restoring Firefox from background

Status: VERIFIED FIXED

(Firefox for iOS :: Login Management, defect, P1)

Description

[Simon Basca [:SimonB]]

Attachment: Client 24-11-16 15-06.crash

Build: 6.0b4
Device: iPad mini 4
iOS: 10.1.1

Steps to reproduce:
1. Tap on a login from Settings -> Logins
2. Tap Edit
3. Select a login
4. Tap Delete -> The delete confirmation prompt is displayed
5. Press the home button
6. Restore Firefox 
7. The delete confirmation prompt is displayed -> Tap delete

Actual results:
- Firefox will crash.

Expected:
- The delete confirmation prompt should be dismissed when backgrounding Firefox.

Comment 1

[Stephan Leroux [:sleroux]]

Attachment: 2016-11-24_15-05-18.7320_+0200-2ceda6d445cc1d3a71b4bcab8291461976c75e76.crash

I believe this crash that's on beta is the same as this issue.

Comment 2

[Bryan Munar (:bkmunar)]

this also happens when you try to delete from an individual login: press delete, the alert will pop up, background firefox, come back, and then press delete --> crash

Comment 3

[Bryan Munar (:bkmunar)]

Attachment: PR

Comment 4

[Stephan Leroux [:sleroux]]

Comment on attachment 8816622 [details] [review]
PR

Looks good but do we also want to add this patch to master? Might make sense to change the PR to point to there then I can uplift it.

Comment 5

[Bryan Munar (:bkmunar)]

https://github.com/mozilla-mobile/firefox-ios/pull/2270 done

Comment 6

[Bryan Munar (:bkmunar)]

https://github.com/mozilla-mobile/firefox-ios/pull/2270/commits/e214a894989b84a73b7ba4308b1ce607b0cdf8a1

Comment 7

[Stephan Leroux [:sleroux]]

v6.x ec28df591c8d8faa0d9e1f0850e3c4ad2fd626ca

Comment 8

[Simon Basca [:SimonB]]

Verifying as fix on master 6dae35c6.