[Regression] Crash when deleting a login after restoring Firefox from background

VERIFIED FIXED

Status

()

P1
critical
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: SimonB, Assigned: bmunar)

Tracking

({crash, regression, reproducible})

unspecified
All
iOS
crash, regression, reproducible

Firefox Tracking Flags

(fxios-v6.0 affected, fxios-v7.0 verified, fxios6.0+)

Details

(Whiteboard: [MobileAS])

Attachments

(3 attachments)

(Reporter)

Description

2 years ago
Created attachment 8814082 [details]
Client  24-11-16 15-06.crash

Build: 6.0b4
Device: iPad mini 4
iOS: 10.1.1

Steps to reproduce:
1. Tap on a login from Settings -> Logins
2. Tap Edit
3. Select a login
4. Tap Delete -> The delete confirmation prompt is displayed
5. Press the home button
6. Restore Firefox 
7. The delete confirmation prompt is displayed -> Tap delete

Actual results:
- Firefox will crash.

Expected:
- The delete confirmation prompt should be dismissed when backgrounding Firefox.
(Reporter)

Updated

2 years ago
Keywords: regression
Summary: Crash when deleting a login after restoring Firefox from background → [Regression] Crash when deleting a login after restoring Firefox from background
Created attachment 8814091 [details]
2016-11-24_15-05-18.7320_+0200-2ceda6d445cc1d3a71b4bcab8291461976c75e76.crash

I believe this crash that's on beta is the same as this issue.
Iteration: --- → 1.9
tracking-fxios: ? → 6.0+
Priority: -- → P1
Whiteboard: [MobileAS]

Updated

2 years ago
Iteration: 1.9 → 1.10
(Assignee)

Comment 2

2 years ago
this also happens when you try to delete from an individual login: press delete, the alert will pop up, background firefox, come back, and then press delete --> crash
(Assignee)

Updated

2 years ago
Assignee: nobody → bmunar
(Assignee)

Comment 3

2 years ago
Created attachment 8816622 [details] [review]
PR
Attachment #8816622 - Flags: review?(sleroux)
Comment on attachment 8816622 [details] [review]
PR

Looks good but do we also want to add this patch to master? Might make sense to change the PR to point to there then I can uplift it.
Attachment #8816622 - Flags: review?(sleroux) → review+
(Assignee)

Comment 6

2 years ago
https://github.com/mozilla-mobile/firefox-ios/pull/2270/commits/e214a894989b84a73b7ba4308b1ce607b0cdf8a1
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Whiteboard: [MobileAS] → [MobileAS][needsuplift]
v6.x ec28df591c8d8faa0d9e1f0850e3c4ad2fd626ca
Whiteboard: [MobileAS][needsuplift] → [MobileAS]
(Reporter)

Comment 8

2 years ago
Verifying as fix on master 6dae35c6.
status-fxios-v7.0: affected → verified
(Reporter)

Updated

2 years ago
Status: RESOLVED → VERIFIED

Updated

2 years ago
Iteration: 1.10 → 1.11
You need to log in before you can comment on or make changes to this bug.