LDAP C++ string type mismatch bustage

RESOLVED FIXED in Thunderbird 53.0

Status

Thunderbird
Address Book
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: aleth, Unassigned)

Tracking

unspecified
Thunderbird 53.0

Thunderbird Tracking Flags

(thunderbird52 fixed, thunderbird53 fixed)

Details

(Reporter)

Description

6 months ago
Linux:
/builds/slave/tb-c-cen-lx-000000000000000000/build/ldap/xpcom/src/nsLDAPSecurityGlue.cpp:180:69: error: no matching function for call to 'nsISocketProvider::AddToSocket(int, char*&, int&, std::nullptr_t, const nsAFlatCString&, int, PRFileDesc*&, nsGetterAddRefs<nsISupports>)'
make[5]: *** [nsLDAPSecurityGlue.o] Error 1
make[4]: *** [ldap/xpcom/src/target] Error 2


OSX/Windows:
/builds/slave/tb-c-cen-m64-00000000000000000/build/ldap/xpcom/src/nsLDAPSecurityGlue.cpp:178:50: error: no viable conversion from 'const nsAFlatCString' (aka 'const nsCString') to 'const mozilla::NeckoOriginAttributes'
make[6]: *** [nsLDAPSecurityGlue.o] Error 1
make[5]: *** [ldap/xpcom/src/target] Error 2
(Reporter)

Comment 1

6 months ago
Regression window 47f42f21541b - 34fce7c12173
From OSX/Windows error message it could be bug 1315143.

Comment 3

6 months ago
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=39b05b60ee883ca8902bb4e81cb445a04cdabba3

I'll take the bug unless someone else wants it. I have to go out for dinner and set off a local compile before.

Comment 4

6 months ago
You can see the solution here:
https://hg.mozilla.org/mozilla-central/rev/498b09513061#l4.12

Comment 5

6 months ago
https://hg.mozilla.org/comm-central/rev/84b356fa5bdcd06873d297a689452e32dcee3d6e
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0

Comment 6

6 months ago
Bug 1315143 just got uplifted to Aurora, so here we go, too:
https://hg.mozilla.org/releases/comm-aurora/rev/ea459696ff47f65f8f909bea4eaf5076e9d1182b

Updated

6 months ago
status-thunderbird52: --- → fixed
status-thunderbird53: --- → fixed
You need to log in before you can comment on or make changes to this bug.