Remove String generics uses in browser/base/content

RESOLVED FIXED in Firefox 53

Status

()

Core
Audio/Video: Playback
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: anba, Assigned: anba)

Tracking

Trunk
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
The various String generic methods are non-standard APIs and we plan to warn when they're used (bug 1319926) and eventually want to remove them completely (bug 1222552). As a first step we need to replace all String generic uses in Firefox with the counterpart from String.prototype.


In browser/base/content/browser-media.js, String.trim needs to be replaced with a call to String.prototype.trim.
(Assignee)

Comment 1

a year ago
Created attachment 8814236 [details] [diff] [review]
bug1320144.patch
Attachment #8814236 - Flags: review?(gijskruitbosch+bugs)
Attachment #8814236 - Flags: review?(gijskruitbosch+bugs) → review+
(Assignee)

Comment 2

a year ago
Thanks for reviewing!
Keywords: checkin-needed

Comment 3

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c90a24c73fff
Remove String generics uses in browser/base/content. r=gijs
Keywords: checkin-needed

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c90a24c73fff
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.