Closed Bug 1320144 Opened 6 years ago Closed 6 years ago

Remove String generics uses in browser/base/content

Categories

(Core :: Audio/Video: Playback, defect)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: anba, Assigned: anba)

References

Details

Attachments

(1 file)

bug1320144.patch
1.55 KB, patch
Gijs
: review+
Details | Diff | Splinter Review 
The various String generic methods are non-standard APIs and we plan to warn when they're used (bug 1319926) and eventually want to remove them completely (bug 1222552). As a first step we need to replace all String generic uses in Firefox with the counterpart from String.prototype.


In browser/base/content/browser-media.js, String.trim needs to be replaced with a call to String.prototype.trim.
Attached patch bug1320144.patch — — Splinter Review 

        Attachment #8814236 -
        Flags: review?(gijskruitbosch+bugs)

    
  

        Attachment #8814236 -
        Flags: review?(gijskruitbosch+bugs) → review+

    
    

    
  
Thanks for reviewing!
Keywords: checkin-needed

    
    

    
  
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c90a24c73fff
Remove String generics uses in browser/base/content. r=gijs
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/c90a24c73fff
Status: ASSIGNED → RESOLVED
Closed: 6 years ago

          status-firefox53:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53

          You need to log in
          before you can comment on or make changes to this bug.