ICE consent signals connected too earlier for non bundled transports

RESOLVED FIXED in Firefox 52

Status

()

Core
WebRTC: Networking
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: drno, Assigned: drno)

Tracking

(Blocks: 1 bug)

52 Branch
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 unaffected, firefox51 unaffected, firefox52 fixed, firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Blocks: 1316200
(Assignee)

Updated

2 years ago
Duplicate of this bug: 1316765

Comment 3

2 years ago
mozreview-review
Comment on attachment 8814178 [details]
Bug 1320150: only fire consent when previously connected.

https://reviewboard.mozilla.org/r/95440/#review96060

Looks good!
Attachment #8814178 - Flags: review?(mfroman) → review+

Comment 4

2 years ago
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/autoland/rev/405a08f9905b
only fire consent when previously connected. r=mjf
(Assignee)

Updated

2 years ago
Depends on: 852665
(Assignee)

Updated

2 years ago
status-firefox50: --- → unaffected
status-firefox51: --- → unaffected
status-firefox52: --- → affected
status-firefox53: --- → affected
(Assignee)

Comment 5

2 years ago
Comment on attachment 8814178 [details]
Bug 1320150: only fire consent when previously connected.

Approval Request Comment
[Feature/Bug causing the regression]: Landing of bug 852665 in 52 caused this.

[User impact if declined]: Some WebRTC services could assume the connection is already established even though not everything is connected yet.

[Is this code covered by automated tests?] Yes bug 1316200 has mochitest work which verifies this.

[Has the fix been verified in Nightly?] I have a mochitests patch over in bug 1316200 which tripped over this and thus verifies the correct/expected behavior.

[Needs manual test from QE? If yes, steps to reproduce]: No.

[List of other uplifts needed for the feature/fix]: None

[Is the change risky?]: No.

[Why is the change risky/not risky?]: This patch only adds another safe guard so the signal to JS from patch 852665 doesn't fire too early.

[String changes made/needed]: N/A
Attachment #8814178 - Flags: approval-mozilla-aurora?

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/405a08f9905b
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment on attachment 8814178 [details]
Bug 1320150: only fire consent when previously connected.

fix a new webrtc bug in aurora52
Attachment #8814178 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 8

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/0277a89270ff
status-firefox52: affected → fixed
You need to log in before you can comment on or make changes to this bug.