Closed Bug 1320150 Opened 3 years ago Closed 3 years ago

ICE consent signals connected too earlier for non bundled transports

Categories

(Core :: WebRTC: Networking, defect, P1)

52 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: drno, Assigned: drno)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Blocks: 1316200
Duplicate of this bug: 1316765
Comment on attachment 8814178 [details]
Bug 1320150: only fire consent when previously connected.

https://reviewboard.mozilla.org/r/95440/#review96060

Looks good!
Attachment #8814178 - Flags: review?(mfroman) → review+
Pushed by drno@ohlmeier.org:
https://hg.mozilla.org/integration/autoland/rev/405a08f9905b
only fire consent when previously connected. r=mjf
Depends on: 852665
Comment on attachment 8814178 [details]
Bug 1320150: only fire consent when previously connected.

Approval Request Comment
[Feature/Bug causing the regression]: Landing of bug 852665 in 52 caused this.

[User impact if declined]: Some WebRTC services could assume the connection is already established even though not everything is connected yet.

[Is this code covered by automated tests?] Yes bug 1316200 has mochitest work which verifies this.

[Has the fix been verified in Nightly?] I have a mochitests patch over in bug 1316200 which tripped over this and thus verifies the correct/expected behavior.

[Needs manual test from QE? If yes, steps to reproduce]: No.

[List of other uplifts needed for the feature/fix]: None

[Is the change risky?]: No.

[Why is the change risky/not risky?]: This patch only adds another safe guard so the signal to JS from patch 852665 doesn't fire too early.

[String changes made/needed]: N/A
Attachment #8814178 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/405a08f9905b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment on attachment 8814178 [details]
Bug 1320150: only fire consent when previously connected.

fix a new webrtc bug in aurora52
Attachment #8814178 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.