Closed
Bug 1320235
Opened 7 years ago
Closed 7 years ago
test timer flood scenario
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla53
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
Attachments
(1 file, 1 obsolete file)
5.70 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
We should add a timer flood test in order exercising the improvements from bug 1300659. This code is too fragile and could easily regress in the future without a test running in automation.
Assignee | ||
Comment 1•7 years ago
|
||
This tests that we can load iframes, perform network requests, and requestAnimationFrame() calls during a timer flood. Try build with test on current tree: https://treeherder.mozilla.org/#/jobs?repo=try&revision=09b55c260f590845da700e3ebb3f664f087fe2c2 Try build with test on tree with bug 1300659 effectively backed out. This should show that the test times out or crashes without our timer improvements. https://treeherder.mozilla.org/#/jobs?repo=try&revision=925d3869763b96eeccb35ed9e1b76e5df41185a9
Assignee | ||
Comment 2•7 years ago
|
||
Comment on attachment 8814283 [details] [diff] [review] Test that the browser continues to function during timer floods. r=bz Boris, can you review this test? It basically triggers an exponential timer flood and then tries to do various things: 1. Load some frames 2. Perform some network requests 3. Run some requestAnimationFrame() callbacks The previous try runs show this passes with current tree, but times out without the anti-flood timer patches (that have already landed).
Flags: needinfo?(bzbarsky)
![]() |
||
Comment 3•7 years ago
|
||
Comment on attachment 8814283 [details] [diff] [review] Test that the browser continues to function during timer floods. r=bz r=me but maybe add a comment about running rAF for 5s in the line that does the 5*60 bit?
Flags: needinfo?(bzbarsky)
Attachment #8814283 -
Flags: review+
Assignee | ||
Comment 4•7 years ago
|
||
Added comments. Also, I switched the flood window to be a child iframe. I don't want this test to suddenly work just because separate windows are in a different process, etc. I discussed this with Boris in IRC and he was ok with it. New try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=db8b2cc548ab89eb9976059ab6df38e2b57f38fc Try with timer flood protections removed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=44ec12461b8229db1f620be95ba2e579b9c1c39e
Attachment #8814283 -
Attachment is obsolete: true
Attachment #8814962 -
Flags: review+
Pushed by bkelly@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9907f708f3fb Test that the browser continues to function during timer floods. r=bz
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9907f708f3fb
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Assignee | ||
Comment 7•7 years ago
|
||
Since bug 1300659 landed on FF52 I uplifted the test as well: https://hg.mozilla.org/releases/mozilla-aurora/rev/3fa3896980f6726c3897ce1645a839996d5d5e8b
status-firefox52:
--- → fixed
Updated•4 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•