1320272 - Contacts sidebar: Implement Ctrl+I keyboard shortcut to edit the properties of selected AND focused contact (ux-consistency with TB address book and MAC default shortcut for "Properties")

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, enhancement)

Description

[Thomas D. (:thomas8)]

+++ This bug was initially created as a clone of Bug #998312 +++

For all the reasons mentioned in Bug 998312 (with much detail), we surely also want to offer this keyboard shortcut to users:

Ctrl+I on selected and focused contact/list in contact side bar
--> Edit contact/list properties

Cmd/Ctrl+I is the MAC default shortcut for properties (like Alt+Enter on Windows/Linux).
We also offer both shortcuts in ABView of main AB (Directory pane needs to be done).
And those shortcuts can never do anything else on a selected and focused contact because that would violate the standards.

Richard, can I please have a thumbs-up...

Comment 1

[Thomas D. (:thomas8)]

ui-r?paenglab --> comment 0

Comment 2

[Richard Marti (:Paenglab)]

This makes sense to be consistent.

Comment 3

[Thomas D. (:thomas8)]

Simple fix (tested working locally on Windows)...

https://dxr.mozilla.org/comm-central/source/mail/components/addrbook/content/abContactsPanel.js

> function contactsListOnKeyPress(aEvent)
> {
>   switch (aEvent.key) {
>     case "Enter":
>       if (aEvent.altKey) {
>         goDoCommand("cmd_properties");
>       }
      case "i":
        if (aEvent.ctrlKey) {
          goDoCommand("cmd_properties");
        }
    }
  }

Not sure how to fix this for MAC, but fixing for Windows also helps...

Comment 4

[Thomas D. (:thomas8)]

Attachment: Patch: Ctrl+I for contacts sidebar item properties

Simple Fix!

Can even be landed at any time, those four lines don't hurt much.

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 8815896 [details] [diff] [review]
Patch: Ctrl+I for contacts sidebar item properties

Looks good and simplicity of code should allow me to r+

ui-r isn't needed on this change.

Comment 6

[Thomas D. (:thomas8)]

I fixed this in a better way in bug 1322032.

https://hg.mozilla.org/comm-central/diff/8f2f953f2ed3/mail/components/addrbook/content/abContactsPanel.xul#l1.50

+  <keyset id="keyset_abContactsPanel">
+    <!-- This key (key_delete) does not trigger any command, but it is used
+         only to show the hotkey on the corresponding menuitem. -->
+    <key id="key_delete" keycode="VK_DELETE"/>
+#ifdef XP_MACOSX
+    <key id="key_properties" modifiers="accel" key="&propertiesCmd.key;" command="cmd_properties"/>
+#else
+    <key id="key_properties" modifiers="alt" keycode="VK_RETURN" command="cmd_properties"/>
+    <key id="key_properties2" modifiers="accel" key="&propertiesCmd.key;" command="cmd_properties"/>    <!-- Ctrl+I -->
+#endif
+  </keyset>

So on Windows and Linux, for maximum convenience we allow both, Alt+Enter (Windows platform shortcut for properties) and Ctrl+I (Mac platform shortcut for properties).

I think someone mentioned that Alt+Enter is used for something else on MAC, or at least it might be, so MAC only has Ctrl+I.

Comment 7

[Thomas D. (:thomas8)]

So the last piece in the ux-consistency puzzle of cmd_properties keyboard shortcuts is bug 1319040, Alt+Enter for directory pane of AB.