Closed Bug 1320304 Opened 5 years ago Closed 5 years ago
Firebug theme - Wrong height of Inspector side panel tabs
Side panel tabs are having wrong height in Firebug theme. See the attached screenshot. Honza
A few comments. General styles for the tab control are here: https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/components/tabs/tabs.css Styles for the tabbar (build on top of tabs) are here: https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/components/tabs/tabbar.css Styles specific to the Inspector panel are here: https://dxr.mozilla.org/mozilla-central/source/devtools/client/themes/inspector.css We need to figure out what is the best place for the fix (depending how generic is it). Honza
Priority: -- → P2
In linux atleast this small change works like a charm.
Firebug theme: - fixed inspector side panel tab height - fixed network monitor side panel tab height
Tab heights in inspector and network monitor sidebar - before and after fix (Linux)
Comment on attachment 8815610 [details] [diff] [review] fix-1320304-2.patch Review of attachment 8815610 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me, thanks for working on this! Hozna
Attachment #8815610 - Flags: review?(odvarko) → review+
Hey Honza, Is "checkin-needed" keyword applicable now ?
(In reply to Ruturaj Vartak from comment #6) > Hey Honza, > Is "checkin-needed" keyword applicable now ? Yes Honza
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0c212b76bca6 Firebug theme - Wrong height of Inspector, Network side panel tabs. r=Honza
I have reproduced this bug with Nightly 53.0a1 (2016-11-25) (64-bit) on windows 7 , 64 Bit ! This bug's fix is verified with latest Nightly Build ID 20161210030206 User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0 [bugday-20161207]
I have reproduced this bug with Nightly 53.0a1 (2016-11-25) (64-bit) on Ubuntu 16.04 The bug's fix is now verified on latest Nightly 55.0a1. Nightly 55.0a1: Build ID 20170420100256 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0 [testday: 20170421]
You need to log in before you can comment on or make changes to this bug.