Closed Bug 1320304 Opened 5 years ago Closed 5 years ago

Firebug theme - Wrong height of Inspector side panel tabs


(DevTools :: General, defect, P2)



(firefox53 fixed)

Firefox 53
Tracking Status
firefox53 --- fixed


(Reporter: Honza, Assigned: ruturaj, Mentored)


(Keywords: good-first-bug)


(3 files, 1 obsolete file)

Attached image tabs.png
Side panel tabs are having wrong height in Firebug theme. See the attached screenshot.

A few comments.

General styles for the tab control are here:

Styles for the tabbar (build on top of tabs) are here:

Styles specific to the Inspector panel are here:

We need to figure out what is the best place for the fix (depending how generic is it).

Mentor: odvarko
Keywords: good-first-bug
Priority: -- → P2
Assignee: nobody → ruturaj
Attached patch fix-1320304-1.patch (obsolete) — Splinter Review
In linux atleast this small change works like a charm.
Attachment #8814645 - Flags: review?(odvarko)
Firebug theme:
- fixed inspector side panel tab height
- fixed network monitor side panel tab height
Attachment #8814645 - Attachment is obsolete: true
Attachment #8814645 - Flags: review?(odvarko)
Attachment #8815610 - Flags: review?(odvarko)
Attached image tab-height.png
Tab heights in inspector and network monitor sidebar - before and after fix (Linux)
Comment on attachment 8815610 [details] [diff] [review]

Review of attachment 8815610 [details] [diff] [review]:

Looks good to me, thanks for working on this!

Attachment #8815610 - Flags: review?(odvarko) → review+
Hey Honza,
Is "checkin-needed" keyword applicable now ?
Flags: needinfo?(odvarko)
(In reply to Ruturaj Vartak from comment #6)
> Hey Honza,
> Is "checkin-needed" keyword applicable now ?

Flags: needinfo?(odvarko)
Keywords: checkin-needed
Pushed by
Firebug theme - Wrong height of Inspector, Network side panel tabs. r=Honza
Keywords: checkin-needed
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
I have reproduced this bug with Nightly 53.0a1 (2016-11-25) (64-bit) on windows 7 , 64 Bit ! 

This bug's fix is verified with latest Nightly

Build ID          20161210030206
User Agent        Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0 

QA Whiteboard: [good first verify]
I have reproduced this bug with Nightly 53.0a1 (2016-11-25) (64-bit) on Ubuntu 16.04
The bug's fix is now verified on latest Nightly 55.0a1.

Nightly 55.0a1:

Build ID 	20170420100256
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

[testday: 20170421]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.