Use :-moz-focusring instead of :focus in notification.css

RESOLVED FIXED in Firefox 53

Status

()

Toolkit
Themes
RESOLVED FIXED
9 months ago
8 months ago

People

(Reporter: dao, Assigned: Hamel Joshi, Mentored)

Tracking

({good-first-bug, regression})

Trunk
mozilla53
good-first-bug, regression
Points:
---

Firefox Tracking Flags

(firefox50 unaffected, firefox51 unaffected, firefox52 unaffected, firefox53 fixed)

Details

(Whiteboard: [good first bug][lang=css])

Attachments

(1 attachment)

(Reporter)

Description

9 months ago
:-moz-focusring follows platform conventions for when to draw a focus ring; :focus doesn't.

Affected files:

toolkit/themes/linux/global/notification.css
toolkit/themes/osx/global/notification.css
toolkit/themes/windows/global/notification.css
(Reporter)

Updated

9 months ago
Keywords: regression
(Assignee)

Comment 1

9 months ago
Hi Dão,

I would like to work on this bug item. Is this just a simple change of :focus to :-moz-focusring in the various files?

Thanks
(Reporter)

Comment 2

9 months ago
(In reply to Hamel Joshi from comment #1)
> Hi Dão,
> 
> I would like to work on this bug item. Is this just a simple change of
> :focus to :-moz-focusring in the various files?

Yep, that's it.
(Assignee)

Comment 3

9 months ago
Created attachment 8814488 [details] [diff] [review]
Bug 1320317 - Changed :focus to :-moz-focusring in notification.css files.
Attachment #8814488 - Flags: review?(dao+bmo)
(Assignee)

Comment 4

9 months ago
Hi Dão,

I have attached a patch for this bug so that it can be reviewed.

Thanks
(Reporter)

Comment 5

9 months ago
Comment on attachment 8814488 [details] [diff] [review]
Bug 1320317 - Changed :focus to :-moz-focusring in notification.css files.

Looks good, thanks!
Attachment #8814488 - Flags: review?(dao+bmo) → review+
(Reporter)

Updated

9 months ago
Assignee: nobody → joshihamel

Comment 6

9 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f7557f3e492
Use :-moz-focusring instead of :focus in notification.css. r=dao

Comment 7

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5f7557f3e492
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
status-firefox50: --- → unaffected
status-firefox51: --- → unaffected
status-firefox52: --- → unaffected
You need to log in before you can comment on or make changes to this bug.