Closed
Bug 1320343
Opened 8 years ago
Closed 8 years ago
Preferences::SetBool called from the content process in VRManager
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: daoshengmu)
References
Details
Attachments
(1 file)
When you run a debug build (for example to run tests) we print this message:
[Child 26078] WARNING: ENSURE_MAIN_PROCESS failed. Cannot SetBool from content process: dom.gamepad.extensions.enabled: file /home/ehsan/moz/src3/modules/libpref/Preferences.cpp, line 1561
This is coming from <http://searchfox.org/mozilla-central/rev/9a3ab17838f039aab023837d905115f8990e442e/gfx/vr/VRManager.cpp#99> added in bug 1299932.
Daosheng, can you please fix this? Thanks!
Flags: needinfo?(dmu)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → dmu
Flags: needinfo?(dmu)
Assignee | ||
Comment 1•8 years ago
|
||
Sure, this is my mistake.
Reporter | ||
Comment 2•8 years ago
|
||
Note that the SetBool function returns without doing anything in the content process, so there may be a logic bug hiding somewhere...
Thanks for looking into it!
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•8 years ago
|
||
(In reply to :Ehsan Akhgari from comment #2)
> Note that the SetBool function returns without doing anything in the content
> process, so there may be a logic bug hiding somewhere...
>
> Thanks for looking into it!
This is because I set this Preference in the GPU process, not the Content process. Probably, we need to modify the warning message as well.
Comment 5•8 years ago
|
||
mozreview-review |
Comment on attachment 8814592 [details]
Bug 1320343 - Avoid to set Preference in the GPU process;
https://reviewboard.mozilla.org/r/95772/#review96254
LGTM, Thanks!
Attachment #8814592 -
Flags: review?(kgilbert) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0f7296d6e742
Avoid to set Preference in the GPU process; r=kip
Keywords: checkin-needed
Comment 7•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•