1320343 - Preferences::SetBool called from the content process in VRManager

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[(no longer active)]

When you run a debug build (for example to run tests) we print this message:

[Child 26078] WARNING: ENSURE_MAIN_PROCESS failed. Cannot SetBool from content process: dom.gamepad.extensions.enabled: file /home/ehsan/moz/src3/modules/libpref/Preferences.cpp, line 1561

This is coming from <http://searchfox.org/mozilla-central/rev/9a3ab17838f039aab023837d905115f8990e442e/gfx/vr/VRManager.cpp#99> added in bug 1299932.

Daosheng, can you please fix this?  Thanks!

Comment 1

[Daosheng Mu[:daoshengmu]]

Sure, this is my mistake.

Comment 2

[(no longer active)]

Note that the SetBool function returns without doing anything in the content process, so there may be a logic bug hiding somewhere...

Thanks for looking into it!

Comment 3

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1320343 - Avoid to set Preference in the GPU process;

Review commit: https://reviewboard.mozilla.org/r/95772/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95772/

Comment 4

[Daosheng Mu[:daoshengmu]]

(In reply to :Ehsan Akhgari from comment #2)
> Note that the SetBool function returns without doing anything in the content
> process, so there may be a logic bug hiding somewhere...
> 
> Thanks for looking into it!

This is because I set this Preference in the GPU process, not the Content process. Probably, we need to modify the warning message as well.

Comment 5

[:kip (Kearwood Gilbert)]

Comment on attachment 8814592 [details]
Bug 1320343 - Avoid to set Preference in the GPU process;

https://reviewboard.mozilla.org/r/95772/#review96254

LGTM, Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f7296d6e742
Avoid to set Preference in the GPU process; r=kip

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0f7296d6e742