Preferences::SetBool called from the content process in VRManager

RESOLVED FIXED in Firefox 53

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Ehsan, Assigned: daoshengmu)

Tracking

unspecified
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

When you run a debug build (for example to run tests) we print this message:

[Child 26078] WARNING: ENSURE_MAIN_PROCESS failed. Cannot SetBool from content process: dom.gamepad.extensions.enabled: file /home/ehsan/moz/src3/modules/libpref/Preferences.cpp, line 1561

This is coming from <http://searchfox.org/mozilla-central/rev/9a3ab17838f039aab023837d905115f8990e442e/gfx/vr/VRManager.cpp#99> added in bug 1299932.

Daosheng, can you please fix this?  Thanks!
Flags: needinfo?(dmu)
Assignee: nobody → dmu
Flags: needinfo?(dmu)
Sure, this is my mistake.
Note that the SetBool function returns without doing anything in the content process, so there may be a logic bug hiding somewhere...

Thanks for looking into it!
(In reply to :Ehsan Akhgari from comment #2)
> Note that the SetBool function returns without doing anything in the content
> process, so there may be a logic bug hiding somewhere...
> 
> Thanks for looking into it!

This is because I set this Preference in the GPU process, not the Content process. Probably, we need to modify the warning message as well.
Comment on attachment 8814592 [details]
Bug 1320343 - Avoid to set Preference in the GPU process;

https://reviewboard.mozilla.org/r/95772/#review96254

LGTM, Thanks!
Attachment #8814592 - Flags: review?(kgilbert) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0f7296d6e742
Avoid to set Preference in the GPU process; r=kip
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0f7296d6e742
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.