1320349 - The autoland repository bypasses the WebIDL hook

Status: RESOLVED INVALID

(Conduit Graveyard :: Transplant, defect)

Description

[(no longer active)]

<https://hg.mozilla.org/integration/autoland/rev/83adb3995ae6> from bug 1299932 landed without a review from a DOM peer which violates our policy.  It seems like the WebIDL hook isn't enabled for this repository, which is weird since it is enabled for inbound and I would expect the autoland repo hooks to match inbound at least.

While this hole is open people can keep landing unreviewed patches.  I'd appreciate if we fix this ASAP.  Thanks.

Comment 1

[Daosheng Mu[:daoshengmu]]

(In reply to :Ehsan Akhgari from comment #0)
> <https://hg.mozilla.org/integration/autoland/rev/83adb3995ae6> from bug
> 1299932 landed without a review from a DOM peer which violates our policy. 
> It seems like the WebIDL hook isn't enabled for this repository, which is
> weird since it is enabled for inbound and I would expect the autoland repo
> hooks to match inbound at least.
> 
> While this hole is open people can keep landing unreviewed patches.  I'd
> appreciate if we fix this ASAP.  Thanks.

I think qDot is a dom peer, right? I ask him before sending the r?

Comment 2

[Boris Zbarsky [:bzbarsky]]

Yes, qdot is a dom peer, both per https://wiki.mozilla.org/Modules/Core#Document_Object_Model and per https://hg.mozilla.org/hgcustom/version-control-tools/file/6298a2195598/hghooks/mozhghooks/prevent_webidl_changes.py#l57

Comment 3

[(no longer active)]

Oh nice, I didn't know that!  :-)

Comment 4

[Gregory Szorc [:gps]]

And I confirmed that the hook is enabled on the autoland repo.