Closed Bug 1320359 Opened 4 years ago Closed 4 years ago

EventRep should show the target property

Categories

(DevTools :: Shared Components, defect, P2)

49 Branch
defect

Tracking

(firefox53 fixed)

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Details

Attachments

(2 files)

The EventRep calls the Grip one but don't passes the `mode` neither `objectLink` props.
Assignee: nobody → chevobbe.nicolas
Please ignore comment 0, this was due to a WIP patch.
Re-purposing this to show the target to match the output of the old console
Summary: EventRep does not handle several modes nor objectLink → EventRep should show the target property
Attached image console.png
Just attaching a screenshot showing the difference between the new and old Console UI.

Honza
Comment on attachment 8815478 [details]
Bug 1320359 - Make EventRep displays like events were displayed in old console;

https://reviewboard.mozilla.org/r/96376/#review96780

LGTM!

R+ assuming try is green

Honza
Comment on attachment 8815478 [details]
Bug 1320359 - Make EventRep displays like events were displayed in old console;

https://reviewboard.mozilla.org/r/96376/#review96782
Attachment #8815478 - Flags: review?(odvarko) → review+
(In reply to Jan Honza Odvarko [:Honza] from comment #5)
> 
> R+ assuming try is green

Since it is https://treeherder.mozilla.org/#/jobs?repo=try&revision=70f5bfb57d46074cf2e2e26c1acb7a1966c1dbac, i'm pushing to autoland
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/601cde18dfb4
Make EventRep displays like events were displayed in old console; r=Honza
https://hg.mozilla.org/mozilla-central/rev/601cde18dfb4
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.