1320359 - EventRep should show the target property

Status: RESOLVED FIXED

(DevTools :: Shared Components, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

The EventRep calls the Grip one but don't passes the `mode` neither `objectLink` props.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Please ignore comment 0, this was due to a WIP patch.
Re-purposing this to show the target to match the output of the old console

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Attachment: console.png

Just attaching a screenshot showing the difference between the new and old Console UI.

Honza

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1320359 - Make EventRep displays like events were displayed in old console;

Add a target property and show the event name (and modifiers if any) in the title.
Minor edit in GripRep to allow to pass a title as a prop.
Edit tests accordingly, and add some to test node highlighting.

Review commit: https://reviewboard.mozilla.org/r/96376/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96376/

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

TRY looks fine https://treeherder.mozilla.org/#/jobs?repo=try&revision=70f5bfb57d46074cf2e2e26c1acb7a1966c1dbac

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8815478 [details]
Bug 1320359 - Make EventRep displays like events were displayed in old console;

https://reviewboard.mozilla.org/r/96376/#review96780

LGTM!

R+ assuming try is green

Honza

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8815478 [details]
Bug 1320359 - Make EventRep displays like events were displayed in old console;

https://reviewboard.mozilla.org/r/96376/#review96782

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Jan Honza Odvarko [:Honza] from comment #5)
> 
> R+ assuming try is green

Since it is https://treeherder.mozilla.org/#/jobs?repo=try&revision=70f5bfb57d46074cf2e2e26c1acb7a1966c1dbac, i'm pushing to autoland

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/601cde18dfb4
Make EventRep displays like events were displayed in old console; r=Honza

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/601cde18dfb4