1320423 - Crash in nsFrame::FillCursorInformationFromStyle

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

This bug was filed from the Socorro interface and is 
report bp-5c6a1d25-a3da-4687-b5f9-74c3c2161123.
=============================================================

Low volume crash that first appeared in the 11-22 Nightly with a single crash on Windows, but has since had 11 crashes for 11-23, 8 for 11-24, and 7 for 11-25 (#21 top crash). The 11-22 crash looks normal, so assuming a regression from 11-22 and looking at the regression range [1], I see bug 1310560 as a possible source since it dealt with cursors. Can you take a look, Cameron?

[1] https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b7f895c1dc2e91530240efbf50ac063a0f8a9cb5&tochange=0534254e9a40b4bade2577c631fe4cfa0b5db41d

Comment 1

[Cameron McCormack (:heycam)]

Thanks.  I probably forgot to add some null checks for cursors, now that we store an nsStyleImageRequest even for a failed URL load (but whose GetImageValue() returns null).

Comment 2

[Cameron McCormack (:heycam)]

Attachment: Bug 1320423 - Null check cursor images to handled failed loads.

Review commit: https://reviewboard.mozilla.org/r/95748/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95748/

Comment 3

[Nicholas Nethercote [inactive]]

55 crashes from 18 installations in the past 7 days, so it's more medium-volume.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8814539 [details]
Bug 1320423 - Null check cursor images to handled failed loads.

https://reviewboard.mozilla.org/r/95748/#review95878

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce2b35bf0048
Null check cursor images to handled failed loads. r=dbaron

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ce2b35bf0048