Closed Bug 1320439 Opened 3 years ago Closed 3 years ago
Extensions: browser _action context menus do not work correctly if there are sub-menus
13.63 KB, image/png
58 bytes, text/x-review-board-request
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0 Build ID: 20161125030214 Steps to reproduce: This bug report relates to the changes made in Bug 1253418. browser_action context menus do do not work correctly if there are sub-menu levels. There are at two cases that do not work correctly. To reproduce the problems, first install my 'Tile Tabs WE' add-on, and then follow these steps: CASE A 1. Right-click on the Tile Tabs WE action button to open the context menu. 2. Hover the mouse over the 'New Layout' menu item. This should open a sub-menu showing a 'Default Layout' menu item and 8 other layout menu items (e.g. '2 Tabs - Vertical'). BUT what actually happens is that the correct sub-menu items are preceded by duplicates of the top-level menu items (see attachment). CASE B 1. Right-click on the Tile Tabs WE action button to open the context menu. 2. Hover the mouse over the 'New Layout' menu item to open the sub-menu. 3. Move the mouse over the 'Hide Layout' menu item on the top-level menu. This should just close the sub-menu. BUT what actually happens is that the sub-menu closes and all of the browser_action menu items on the top-level menu disappear. Actual results: CASE A - when a sub-menu opens, spurious menu items are shown on the sub-menu. CASE B - when a sub-menu closes, all of the browser_action top-level menu items disappear. Expected results: CASE A - when a sub-menu opens, only the correct menu items should be shown on the sub-menu. CASE B - when a sub-menu closes, the browser_action top-level menu items should still be shown.
Component: Untriaged → WebExtensions: Untriaged
Product: Firefox → Toolkit
Assignee: nobody → tomica
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 8814764 [details] bug 1320439 - Fix submenus in page_action, browser_action contextMenus, https://reviewboard.mozilla.org/r/95856/#review96150
Attachment #8814764 - Flags: review?(kmaglione+bmo) → review+
Component: WebExtensions: Untriaged → WebExtensions: Frontend
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/1a5839f86e79 Fix submenus in page_action, browser_action contextMenus, r=kmag
I was able to reproduce the initial issue on Firefox 53.0a1 (2016-11-26) under Windows 10 64-bit. Verified fixed on Firefox 53.0a1 (2016-12-01) under Windows 10 64-bit and Ubuntu 16.04 32-bit. The expected items are successfully displayed in sub-menu and the browser_action menu remains displayed while hovering the cursor over the menu items.
You need to log in before you can comment on or make changes to this bug.