1320525 - browser.urlbar.maxCharsForSearchSuggestions pref doesn't work anymore

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, defect)

Description

[Bruce]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20161126004005

Steps to reproduce:

Reproducible in Firefox 50 through 53.

1) Set Google as the default search engine and set it to 'Show search suggestions in location bar results.'
2) Set browser.urlbar.maxCharsForSearchSuggestions to be >20, say 30.
3) In the location bar, start typing (without quotes): 'incremental cash reserve ratio'.


Actual results:

Suggestions display until you have typed 'incremental cash res' - exactly 20 characters. Type another 'e' and no suggestions are displayed.

Screenshot showing the problem: http://i.imgur.com/zoArsig.gif .


Expected results:

browser.urlbar.maxCharsForSearchSuggestions shouldn't be ignored.

Comment 1

[YF (Yang)]

WFM in 51.0b3 (64-bit) & 53.0a1 (2016-11-26) (32-bit) on Win10, although it don't have the results shown, but Browser Console - Network show the request parameters are truncated and sent correctly.

Comment 2

[Bruce]

(In reply to YF (Yang) from comment #1)
> WFM..., although it don't have the results shown...

Could you change the title of the bug to reflect the fact that although the pref works, the results aren't shown? And confirm the bug?
Thanks.

Comment 3

[YF (Yang)]

I tested it again in Fx51.0b6, and see the "incremental cash reserve ratio" when typed "incremental cash reserve rati" and browser.urlbar.maxCharsForSearchSuggestions = 25, including after restart. I see it being truncated correctly, send the "incremental cash reserve".

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

the pref works by disabling the fetching of suggestions if the string goes over the limit, and that's what happens.