Closed Bug 1320621 Opened 8 years ago Closed 8 years ago

--enable-system-hunspell picks up bundled headers

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox-esr45 wontfix, thunderbird_esr45 affected, firefox50 wontfix, firefox51 fixed, firefox52 fixed, firefox53 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox-esr45 --- wontfix
thunderbird_esr45 --- affected
firefox50 --- wontfix
firefox51 --- fixed
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

Attachments

(1 file)

Bug 1320621 - Make sure --enable-system-hunspell picks up system headers.
58 bytes, text/x-review-board-request
glandium
: review+
gchang
: approval-mozilla-aurora+
gchang
: approval-mozilla-beta+
Details 
As downstream adopts Hunspell 1.5 before bug 1318955 it may bump into mismatched prototypes during linking. The issue comes from glue code using LOCAL_INCLUDES vs. CXXFLAGS forgetting the order matters.
Comment on attachment 8814776 [details]
Bug 1320621 - Make sure --enable-system-hunspell picks up system headers.

https://reviewboard.mozilla.org/r/95882/#review96368
Attachment #8814776 - Flags: review?(mh+mozilla) → review+
Keywords: checkin-needed
Assignee: nobody → jbeich
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/02c0dad1974e
Make sure --enable-system-hunspell picks up system headers. r=glandium
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/02c0dad1974e
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment on attachment 8814776 [details]
Bug 1320621 - Make sure --enable-system-hunspell picks up system headers.

Approval Request Comment
[Feature/Bug causing the regression]: --enable-system-hunspell in .mozconfig
[User impact if declined]: Build error or crash depending on how much ABI differs between bundled and system Hunspell
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes, Firefox 53 vs. system Hunspell 1.3 and Firefox 50 vs. system Hunspell 1.5.
[Needs manual test from QE? If yes, steps to reproduce]: No, NPOTB.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Low
[Why is the change risky/not risky?]: Can only break build if bundled headers aren't found with --enable-system-hunspell disabled (default).
[String changes made/needed]: None
Attachment #8814776 - Flags: approval-mozilla-beta?
Attachment #8814776 - Flags: approval-mozilla-aurora?
An old issue gone unnoticed because Hunspell is rarely updated. ESR45 version only needs adjusting for lack of bug 1244743.
status-firefox50: --- → affected
status-firefox51: --- → affected
status-firefox52: --- → affected
status-firefox-esr45: --- → affected
status-thunderbird_esr45: --- → affected
Comment on attachment 8814776 [details]
Bug 1320621 - Make sure --enable-system-hunspell picks up system headers.

Fix a build issue related to hunspell. Beta51+ and Aurora52+. Should be in 51 beta 6.
Attachment #8814776 - Flags: approval-mozilla-beta?
Attachment #8814776 - Flags: approval-mozilla-beta+
Attachment #8814776 - Flags: approval-mozilla-aurora?
Attachment #8814776 - Flags: approval-mozilla-aurora+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: