1320637 - Mark several methods into nsIHTMLInlineTableEditor as noscript

Status: RESOLVED DUPLICATE of bug 1717178

(Core :: DOM: Editor, defect, P3)

Description

[Makoto Kato [:m_kato]]

Except to nsIHTMLInlineTableEditor.inlineTableEditingEnabled, no addons (and c-c) use other methods of nsIHTMLInlineTableEditor.  So we should mark these as [noscript].

Comment 1

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

(In reply to Makoto Kato [:m_kato] from comment #0)

> Except to nsIHTMLInlineTableEditor.inlineTableEditingEnabled, no addons (and
> c-c) use other methods of nsIHTMLInlineTableEditor.  So we should mark these
> as [noscript].

Don't do that please.

1. BlueGriffon's JS code uses nsIHTMLInlineTableEditor

2. when JS code modifies the rendering of a given table directly, for instance
   with direct manipulation of the attributes/elements and not transaction
   involved, nsIHTMLInlineTableEditor is the only way to make sure the table
   handles are correctly refreshed

3. item 2 does matter for BlueGriffon, Thunderbird, Postbox and probably more.

Comment 2

[Makoto Kato [:m_kato]]

https://github.com/therealglazou/bluegriffon/blob/3b28e5e7c91e1de5e19903724c499b4b18052e10/base/content/bluegriffon/bindings/rulers.xml#L127

BlueGriffon seems to use inlineTableEditingEnabled and refreshInlineTableEditingUI only.

Comment 3

[Gregory Pappas [:gregp]]

These methods were removed in bug 1717178