Wrong assertion in jsscript.cpp: MOZ_ASSERT(!srcFun->isAsync());

RESOLVED FIXED in Firefox 52

Status

()

Core
JavaScript Engine
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: arai, Assigned: arai)

Tracking

Trunk
mozilla53
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox-esr45 unaffected, firefox50 unaffected, firefox51 unaffected, firefox52 fixed, firefox53 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

a year ago
CloneInnerInterpretedFunction is called on unwrapped function, that is just a generator at that point, and it can be cloned without any issue.

also, we need to clone unwrapped function if it appears in XUL.
So, the assertion just need to be removed.
(Assignee)

Comment 1

a year ago
Created attachment 8814937 [details] [diff] [review]
Remove wrong assertion in jsscript.cpp.

Just removed the wrong assertion in CloneInnerInterpretedFunction,
and added testcase for cloneAndExecuteScript.
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Attachment #8814937 - Flags: review?(till)
Comment on attachment 8814937 [details] [diff] [review]
Remove wrong assertion in jsscript.cpp.

Review of attachment 8814937 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense.
Attachment #8814937 - Flags: review?(till) → review+
(Assignee)

Comment 3

a year ago
Thank you for reviewing :D
status-firefox50: --- → unaffected
status-firefox51: --- → unaffected
status-firefox52: --- → affected
status-firefox-esr45: --- → unaffected
(Assignee)

Comment 4

a year ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b68b4d00610f0628cb5fac27600670815100f42
Bug 1320697 - Remove wrong assertion in jsscript.cpp. r=till

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1b68b4d00610
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
(Assignee)

Comment 6

a year ago
Created attachment 8815651 [details] [diff] [review]
(mozilla-aurora) Remove wrong assertion in jsscript.cpp. r=till

Approval Request Comment
> [Feature/Bug causing the regression]
bug 1185106

> [User impact if declined]
no user impact
automated test with debug build may hit this wrong assertion when a patch that uses async function is backported to the branch

> [Is this code covered by automated tests?]
yes

> [Has the fix been verified in Nightly?]
yes

> [Needs manual test from QE? If yes, steps to reproduce]
no

> [List of other uplifts needed for the feature/fix]
none

> [Is the change risky?]
no

> [Why is the change risky/not risky?]
just removed wrong assertion and has no effect on non-debug build

> [String changes made/needed]
none
Attachment #8815651 - Flags: review+
Attachment #8815651 - Flags: approval-mozilla-aurora?
Comment on attachment 8815651 [details] [diff] [review]
(mozilla-aurora) Remove wrong assertion in jsscript.cpp. r=till

remove wrong assert for debug builds, aurora52+
Attachment #8815651 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 8

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/b7e54ef9cf8c
status-firefox52: affected → fixed
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.