1320697 - Wrong assertion in jsscript.cpp: MOZ_ASSERT(!srcFun->isAsync());

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tooru Fujisawa [:arai]]

CloneInnerInterpretedFunction is called on unwrapped function, that is just a generator at that point, and it can be cloned without any issue.

also, we need to clone unwrapped function if it appears in XUL.
So, the assertion just need to be removed.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Remove wrong assertion in jsscript.cpp.

Just removed the wrong assertion in CloneInnerInterpretedFunction,
and added testcase for cloneAndExecuteScript.

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 8814937 [details] [diff] [review]
Remove wrong assertion in jsscript.cpp.

Review of attachment 8814937 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense.

Comment 3

[Tooru Fujisawa [:arai]]

Thank you for reviewing :D

Comment 4

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b68b4d00610f0628cb5fac27600670815100f42
Bug 1320697 - Remove wrong assertion in jsscript.cpp. r=till

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1b68b4d00610

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: (mozilla-aurora) Remove wrong assertion in jsscript.cpp. r=till

Approval Request Comment
> [Feature/Bug causing the regression]
bug 1185106

> [User impact if declined]
no user impact
automated test with debug build may hit this wrong assertion when a patch that uses async function is backported to the branch

> [Is this code covered by automated tests?]
yes

> [Has the fix been verified in Nightly?]
yes

> [Needs manual test from QE? If yes, steps to reproduce]
no

> [List of other uplifts needed for the feature/fix]
none

> [Is the change risky?]
no

> [Why is the change risky/not risky?]
just removed wrong assertion and has no effect on non-debug build

> [String changes made/needed]
none

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 8815651 [details] [diff] [review]
(mozilla-aurora) Remove wrong assertion in jsscript.cpp. r=till

remove wrong assert for debug builds, aurora52+

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b7e54ef9cf8c