132071 - enable jprof html output to handle templates

Status: RESOLVED FIXED

(Core :: General, enhancement)

Description

[Dave Morrison]

The HTML report generated by the current version of leaky.cpp doesn't handle the
angle brackets of templates well.  They're not escaped, so they mostly disappear
in the browsed web pages.

Comment 1

[Dave Morrison]

Attachment: adds escape handling for angle brackets in html output

Patch against a somewhat earlier version of leaky.cpp which replaces angle
brackets in generated html output with HTML codes.

Comment 2

[Matthias Versen [:Matti]]

*** Bug 132072 has been marked as a duplicate of this bug. ***

Comment 3

[Matthias Versen [:Matti]]

marking NEW (patch) and assigning to [e-mail] 

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm wonder if we consider std::string portable enough to use in jprof...

Comment 5

[Dave Morrison]

Attachment: A version which avoids std::string - just ol' fashioned C strings

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 75592 [details] [diff] [review]
A version which avoids std::string - just ol' fashioned C strings

>+char *
>+htmlify(char *in)

The indentation in this function is really wacky -- way off house style, and internally inconsistent (sometimes one space instead of two).

>-    
>-    sp->cntP.printReport(fp, this);

I don't think this should be removed.  Any idea why it was removed?

Other than that, it looks fine.  Not sure if it still applies, though.

Sorry I missed this one.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: revised patch

This takes into account my comments on the previous patch (although some of the comments about indentation were actually about tabs).

It also fixes a few things in htmlify:
 * uses |const char| where we should (and reuses p in the counting loop where you were using q)
 * null-terminates the result

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in the above patch to trunk.

Thanks for contributing it, and sorry I lost track of it.