Target i686-unknown-linux-gnu when building rust code for linux32

RESOLVED FIXED in Firefox 53

Status

RESOLVED FIXED
2 years ago
6 months ago

People

(Reporter: rillian, Assigned: rillian)

Tracking

unspecified
mozilla53

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Now that we'd dropped support for linux32 machines without SSE2 support, switch back to the default i686 rust target.

This lets rust code generation take advantage of SSE2 instructions, and simplifies installing dependencies by using use the default stable target for this platform.
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Assignee: nobody → giles
Blocks: 1135640
(Assignee)

Comment 2

2 years ago
Oops, need to update the tooltool manifest too.
Comment hidden (mozreview-request)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8814964 [details]
Bug 1320710 - Target i686 rust code on linux32.

https://reviewboard.mozilla.org/r/96012/#review97412

::: browser/config/tooltool-manifests/linux32/releng.manifest:20
(Diff revision 2)
> -"size": 96275316,
> -"digest": "26c11e34df81f5d7ffafc3492df9c6821f644a2e2eda5cfbbcdb1ac23e4ee196007b417c862c60a97bbf66e4be9c801400990938cd3aefec19b1cf9eaf1a9b54",
> +"size": 94830820,
> +"digest": "6f2a1cf325d957f0328d2d853fc07944a857e872f6e44df15f6ebb45c032c0ebbf52f56c872bc72927ebcdd830002d759dd92e8fc90048b52c07058955c69c4c",

How was this generated?
Attachment #8814964 - Flags: review?(mh+mozilla)
(Assignee)

Comment 5

2 years ago
In https://github.com/rillian/rust-build/

1. repack_rust.py to repackage the upstream builds.
2. manual tooltool add and upload.
3. splat_rust.py to update gecko manifests.

I'll file a bug to update the in-tree versions. I'd like to make taskcluster do all this, but haven't take the time to learn the new dispatch stuff. Do you have the clang builds updating tooltool or another example I could read?
(Assignee)

Comment 6

2 years ago
(In reply to Ralph Giles (:rillian) needinfo me from comment #5)

> I'll file a bug to update the in-tree versions.

This has now landed in bug 1321863.
(Assignee)

Comment 7

2 years ago
mozreview-review-reply
Comment on attachment 8814964 [details]
Bug 1320710 - Target i686 rust code on linux32.

https://reviewboard.mozilla.org/r/96012/#review97412

> How was this generated?

In https://github.com/rillian/rust-build/

1. repack_rust.py to repackage the upstream builds.
2. manual tooltool add and upload.
3. splat_rust.py to update gecko manifests.

I updated the in-tree copy of the scripts in https://bugzilla.mozilla.org/show_bug.cgi?id=1321863
(Assignee)

Updated

2 years ago
Attachment #8814964 - Flags: review?(nfroyd)

Comment 8

2 years ago
mozreview-review
Comment on attachment 8814964 [details]
Bug 1320710 - Target i686 rust code on linux32.

https://reviewboard.mozilla.org/r/96012/#review98356
Attachment #8814964 - Flags: review?(nfroyd) → review+
Comment on attachment 8814964 [details]
Bug 1320710 - Target i686 rust code on linux32.

Canceling ted's review.
Attachment #8814964 - Flags: review?(ted)
(In reply to Ralph Giles (:rillian) needinfo me from comment #5)
> I'll file a bug to update the in-tree versions. I'd like to make taskcluster
> do all this, but haven't take the time to learn the new dispatch stuff. Do
> you have the clang builds updating tooltool or another example I could read?

Make taskcluster do this in what sense?  It should not be hard to add a taskcluster toolchain task to do all the repacking...not sure about the updating of the manifests, though.  Bug 1313111 tracks something more ambitious, but I don't think we'd be able to ditch tooltool.

Comment 11

2 years ago
Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2d14d37c2c99
Target i686 rust code on linux32. r=froydnj

Comment 12

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2d14d37c2c99
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
(In reply to Nathan Froyd [:froydnj] from comment #10)

> Make taskcluster do this in what sense?

I don't have a specific plan. I just wanted to express general intent to continue improving the automation for this.

I think there's a way to access published artifacts from a depending task in taskcluster builds, so it would be nice to hook that up. While we're still running buildbot jobs we'll need to update the tooltool manifests. A task could build and upload packages, then generate the patch, but it would be need to land through normal channels, with a bug created manually or with some not-currently-existing automation access.

Updated

6 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.