Closed Bug 1320743 Opened 3 years ago Closed 3 years ago

Delete PathCG

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: mchang, Assigned: mchang)

Details

Attachments

(1 file, 3 obsolete files)

Since DrawTargetCG is gone too!
Attached patch Delete Path CG (obsolete) — Splinter Review
Deletes mostly everything from PathCG.cpp. Keeps the stuff we use in DrawTargetSkia for subpixel AA text on transparent backgrounds in DrawTargetSkia.
Attachment #8815449 - Flags: review?(lsalzman)
(In reply to Mason Chang [:mchang] from comment #1)
> Created attachment 8815449 [details] [diff] [review]
> Delete Path CG
> 
> Deletes mostly everything from PathCG.cpp. Keeps the stuff we use in
> DrawTargetSkia for subpixel AA text on transparent backgrounds in
> DrawTargetSkia.

Can't we just get rid of even PathBuilderCG and inline the CGPath calls? We don't even really need the validation inside there anymore either, since SkPath will guarantee the sub-path has a MoveTo already, and you can just validate the path before processing by checking SkPath::isFinite once...
Attached patch Delete PathCG (obsolete) — Splinter Review
Attachment #8815449 - Attachment is obsolete: true
Attachment #8815449 - Flags: review?(lsalzman)
Attachment #8815823 - Flags: review?(lsalzman)
Attached patch Delete PathCG (obsolete) — Splinter Review
Attachment #8815823 - Attachment is obsolete: true
Attachment #8815823 - Flags: review?(lsalzman)
Attachment #8815832 - Flags: review?(lsalzman)
Attached patch Delete PathCGSplinter Review
Attachment #8815832 - Attachment is obsolete: true
Attachment #8815832 - Flags: review?(lsalzman)
Attachment #8815833 - Flags: review?(lsalzman)
Comment on attachment 8815833 [details] [diff] [review]
Delete PathCG

CG is finally nuked! Celebrate!
Attachment #8815833 - Flags: review?(lsalzman) → review+
https://hg.mozilla.org/mozilla-central/rev/7940f11b3b42
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.