Closed Bug 1320752 Opened 7 years ago Closed 7 years ago

remove mozilla/Function.h

Categories

(Core :: MFBT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

References

Details

Attachments

(1 file)

We have std::function available now, which is likely to be somewhat more
efficient.
I realized it was silly to try and optimize mozilla::function when
std::function already contains the same optimizations and is just as usable...
Attachment #8815010 - Flags: review?(gsquelart)
Comment on attachment 8815010 [details] [diff] [review]
remove mozilla/Function.h

Review of attachment 8815010 [details] [diff] [review]:
-----------------------------------------------------------------

Nice one, thanks!

r+, as it should work (assuming you've try'd it).

My only comment would be relative to the order of #include's: Sometimes you've put `#include <functional>` at the bottom of the #include section (my personal preference), sometimes near the top (the coding style recommendation). Mostly you are following the existing order in each file, but it would be nice if we could get something consistent one day! [end rant]
Another bug, another day? Maybe when we do automatic formatting? :-)
Attachment #8815010 - Flags: review?(gsquelart) → review+
I was trying to follow existing style; I will leave consistency for the One Formatting Pass To Rule Them All. :)
https://hg.mozilla.org/mozilla-central/rev/1e5621e43ac6
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
See Also: → 1204160
You need to log in before you can comment on or make changes to this bug.