remove mozilla/Function.h

RESOLVED FIXED in Firefox 53

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
We have std::function available now, which is likely to be somewhat more
efficient.
(Assignee)

Comment 1

2 years ago
Created attachment 8815010 [details] [diff] [review]
remove mozilla/Function.h

I realized it was silly to try and optimize mozilla::function when
std::function already contains the same optimizations and is just as usable...
Attachment #8815010 - Flags: review?(gsquelart)
Comment on attachment 8815010 [details] [diff] [review]
remove mozilla/Function.h

Review of attachment 8815010 [details] [diff] [review]:
-----------------------------------------------------------------

Nice one, thanks!

r+, as it should work (assuming you've try'd it).

My only comment would be relative to the order of #include's: Sometimes you've put `#include <functional>` at the bottom of the #include section (my personal preference), sometimes near the top (the coding style recommendation). Mostly you are following the existing order in each file, but it would be nice if we could get something consistent one day! [end rant]
Another bug, another day? Maybe when we do automatic formatting? :-)
Attachment #8815010 - Flags: review?(gsquelart) → review+
(Assignee)

Comment 3

2 years ago
I was trying to follow existing style; I will leave consistency for the One Formatting Pass To Rule Them All. :)

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1e5621e43ac6
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.