Closed Bug 1320755 Opened 5 years ago Closed 5 years ago

Remove dependence of IPDL unit tests on state() method

Categories

(Core :: IPC, defect)

Product:
Core
Component:
IPC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

Bug 1320755 - Remove dependence of IPDL unit tests on state() method.
58 bytes, text/x-review-board-request
dvander
: review+
Details 
As part of the IPDL state machine, there's a state() method on protocols that can be called from C++ to check what the current state is. The behavior of a few IPDL unit tests depends on the result of that method. This can be avoided by manually tracking some state. I'll leave an assertion that the behavior of the manually tracked state matches the IPDL state machine state, and then remove it later in bug 1316757.
Comment on attachment 8815070 [details]
Bug 1320755 - Remove dependence of IPDL unit tests on state() method.

https://reviewboard.mozilla.org/r/96060/#review96212
Attachment #8815070 - Flags: review?(dvander) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/595cee0bbb15
Remove dependence of IPDL unit tests on state() method. r=dvander
https://hg.mozilla.org/mozilla-central/rev/595cee0bbb15
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.