1320798 - [AS] Improve contextual menu item ordering

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[:Grisha Kruglov]

See screenshots [0] of what menu looks like right now. If I want to open a top site item in a new tab, I currently have to perform three actions:
- press the three dots in the top right of the item, opening the menu
- slide the menu (currently there's no affordance to suggest that I could do this...)
- tab the button

We want to minimize amount of effort and optimize discoverability of the "most used" actions, such as "open in new tab".

- As step one we should consider re-ordering items in this list.
- As step two, we should consider optimizing ordering of these items either based on what actions user performs the most, or what actions we deem as most relevant based on the context (e.g. this list might be different for a bookmarked item in top sites vs. a highlighted item).

[0] https://goo.gl/photos/DGb4G33XzcAQgkae7

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Would be interesting to look at telemetry of our current top sites panel to see what users actually do most of the time.

Comment 2

[:Grisha Kruglov]

Seems like we have telemetry for all of the actions in the current menu, with an exception that Open in New Tab and Open in Private Tab are collapsed together. Let's see if I can put together a re:dash dashboard to crunch these numbers.

Comment 3

[:Grisha Kruglov]

Here's the data mapped in re:dash:
- beta population: https://sql.telemetry.mozilla.org/queries/1894/source
- release population (still running while I'm writing this): https://sql.telemetry.mozilla.org/queries/1898/source

First, notes on the data. It's not very isolated, so some caveats apply:
- It's not specific to the Top Sites panel, but gathered from all of our home panels.
- Some actions such as pin/unpin are only available from Top Sites.
- I've excluded "edit bookmark" action, and only tracking is the "edit topsite" action. I might revise this.
- Most actions in the context menu are available on every home panel - "remove", "open in new tab", "open in private tab", etc. The last two are collapsed together (on the device, before transmission), and are shown under "newtab".

Ranking:
1) "removed", by a huge margin, more than 6x of #2. An explanation of this might go along the lines of "people might be using 'remove' while trimming their history, which they might do in little "deletion sprints". Regardless, 6x is telling.

And the rest are very evenly spaced out, more or less as you'd expect:

2) "new tab"/"private tab" (can't distinguish between the two)
3) "add to home screen"
4) "share"
5) "pin" - although recently it took a nose dive to #7
6) "edit" - only top sites action is included here
7) "copy url"
8) "unpin"

Comment 4

[:Grisha Kruglov]

Current menu in Activity Stream (once Bug 1319274 lands and adds pin/unpin items):

<visible without scrolling on an average phone>
- Add/Remove Bookmark
- Pin/Unpin
- Share
- Copy Address
</visible without scrolling>
- Add to Home Screen
<divider>
- Open in New Tab
- Open in Private Tab
<divider>
- Dismiss (shown only for a highlight)
- Delete from History

One way to re-group the menu is by popularity. Top three slots are "hot screen estate", so lets place to most popular actions there:

<visible without scrolling>
- Open in New Tab
- Add to Home Screen
- Dismiss for a Highlight, Delete from History for a Top Site
</visible without scrolling>
- Share
<divider>
- Open in Private Tab
- Add/Remove bookmark
- Pin/Unpin
<divider>
- Copy url
- Edit

Additionally, it might make sense to either remove "Delete from History" from a highlight item context menu, or place it in a de-prioritized location, just below the fold, above "share".
- Argument for removing it: I'm not sure we should sprinkle history editing abilities into a highlights panel, since we already have a dismiss there.
- Against removing it: "remove" action seems pretty popular, so perhaps people will find it particularly useful! And why not have it in, especially if it's below the fold and doesn't affect visibility of other items.

Comment 5

[bbell]

couple points:

- dismiss is fundamentally different from "delete from history" since it only means that you don't need this item here, on the new-tab/topsites panel. this will become important later when we introduce pinning, and reminders 
- sorting by popularity would separate related items

Comment 6

[:Grisha Kruglov]

(In reply to bbell from comment #5)
> - dismiss is fundamentally different from "delete from history" since it
> only means that you don't need this item here, on the new-tab/topsites
> panel. this will become important later when we introduce pinning, and
> reminders

Agreed, and I think that there is a good argument to be made for _just_ keeping Dismiss (see bottom of my Comment 4). As for pinning, it landed last week, and comes with separate Pin/Unpin action items.

> - sorting by popularity would separate related items

Potentially. I've tried to minimize that split in my proposed ordering in Comment 4.

Comment 7

[bbell]

Attachment: New Tab - [e-mail]

What if we parks "Copy Address" and “Add to Homepage” into the share menu? (as they are on desktop)

Then we'll be able to rearrange the menu to be like this

Comment 8

[bbell]

Attachment: New Tab - [e-mail]

Comment 9

[bbell]

Attachment: New Tab - [e-mail]

Comment 10

[:Grisha Kruglov]

Attachment: Pasted image at 2016_12_19 06_45 PM.png

From a chat with Bryan, I think this is the ordering we're going with for now - see middle and right columns.

Comment 11

[:Grisha Kruglov]

Attachment: Bug 1320798 - Re-order context menu items for Activity Stream

Review commit: https://reviewboard.mozilla.org/r/100292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/100292/

Comment 12

[bbell]

Attachment: Example.png

the new menu order

Comment 13

[bbell]

Attachment: example.png

Comment 14

[Andrzej Hunt :ahunt]

Comment on attachment 8820907 [details]
Bug 1320798 - Re-order context menu items for Activity Stream

https://reviewboard.mozilla.org/r/100292/#review101098

Yay!

On a sidenote: it's possible to adjust how much of the menu is shown by default - i.e. what height the menu is when it's first shown, but doing that well might require some clever calculations (we used a hardcoded height for a while, which was subsequently removed in https://hg.mozilla.org/mozilla-central/rev/ee67814f9015 )

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/358981f2f69e
Re-order context menu items for Activity Stream r=ahunt

Comment 16

[:Grisha Kruglov]

(In reply to Andrzej Hunt :ahunt from comment #14)
> Comment on attachment 8820907 [details]
> Bug 1320798 - Re-order context menu items for Activity Stream
> 
> https://reviewboard.mozilla.org/r/100292/#review101098
> 
> Yay!
> 
> On a sidenote: it's possible to adjust how much of the menu is shown by
> default - i.e. what height the menu is when it's first shown, but doing that
> well might require some clever calculations (we used a hardcoded height for
> a while, which was subsequently removed in
> https://hg.mozilla.org/mozilla-central/rev/ee67814f9015 )

I filed a follow-up to figure this out: Bug 1325440

Comment 17

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/358981f2f69e

Comment 18

[Carmen Fat [:cfat] - Ecosystem QA]

Tested on latest Nightly 53.0a1 (2017-01-04) build, using next devices:
- Prestigio Grace 5x (Android 4.4.2);
- Nexus 5 (Android 6.0.1).

The order of the context menu is now similar to the screenshots attached in comment 10 and comment 13.
Please see the next screenshot displaying context menu with and without scrolling for both Top sites and Highlights areas: http://imgur.com/a/kC5KF
Marking this as Verified.