Closed Bug 1320833 Opened 3 years ago Closed 3 years ago

Only generate State enum case for PFoo::State::__Dying when hasReentrantDelete()

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

Details

Attachments

(1 file)

No description provided.
This enum is generated with a case __Dying that is never used unless hasReentrantDelete() holds on the type, so we should just never generate it if we don't need it.
Summary: Only generate State enum case for PFoo:: → Only generate State enum case for PFoo::State::__Dying when hasReentrantDelete()
I think __Error could likewise be only conditionally generated, but I think it makes more sense to just wait to delete it entirely in bug 1316757.
Comment on attachment 8815119 [details]
Bug 1320833 - Only generate State enum case for PFoo::State::__Dying when hasReentrantDelete().

https://reviewboard.mozilla.org/r/96106/#review96300

Good catch.
Attachment #8815119 - Flags: review?(kchen) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/de1a1ae3cab6
Only generate State enum case for PFoo::State::__Dying when hasReentrantDelete(). r=kanru
https://hg.mozilla.org/mozilla-central/rev/de1a1ae3cab6
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.