1320874 - Convert some code in view/ to C++11

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Andi [:andi]]

Using the checkers provided by clang-tidy we can refresh the code to make it use the features of C++11 like:

- auto variables declarations
- default CTORS and DTORS
- using new range loop operators

Comment 1

[Andi [:andi]]

Attachment: Bug 1320874 - Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in view/.

Review commit: https://reviewboard.mozilla.org/r/96210/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96210/

Comment 2

[Markus Stange [:mstange]]

Really, clang-tidy suggests this? I'm not convinced it improves readability nor maintainability.

How has this type of fix gone over in the other bugs that you've filed?

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 8815182 [details]
Bug 1320874 - Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in view/.

https://reviewboard.mozilla.org/r/96210/#review96630

Looks like froydnj r+ed a similar fix in bug 1319752, so if he's fine with it, I'm fine with it. In any case it's not important enough to fight about.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/176260cf74af
Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in view/. r=mstange

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/176260cf74af