Convert some code in view/ to C++11

RESOLVED FIXED in Firefox 53

Status

()

Core
Rewriting and Analysis
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: andi, Assigned: andi)

Tracking

(Blocks: 1 bug)

Trunk
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

11 months ago
Using the checkers provided by clang-tidy we can refresh the code to make it use the features of C++11 like:

- auto variables declarations
- default CTORS and DTORS
- using new range loop operators
Comment hidden (mozreview-request)
(Assignee)

Updated

11 months ago
Attachment #8815182 - Flags: review?(mstange)
(Assignee)

Updated

11 months ago
Assignee: nobody → bpostelnicu
Really, clang-tidy suggests this? I'm not convinced it improves readability nor maintainability.

How has this type of fix gone over in the other bugs that you've filed?

Comment 3

11 months ago
mozreview-review
Comment on attachment 8815182 [details]
Bug 1320874 - Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in view/.

https://reviewboard.mozilla.org/r/96210/#review96630

Looks like froydnj r+ed a similar fix in bug 1319752, so if he's fine with it, I'm fine with it. In any case it's not important enough to fight about.
Attachment #8815182 - Flags: review?(mstange) → review+

Comment 4

11 months ago
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/176260cf74af
Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in view/. r=mstange

Comment 5

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/176260cf74af
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.