Closed Bug 1320874 Opened 3 years ago Closed 3 years ago

Convert some code in view/ to C++11

Categories

(Firefox Build System :: Source Code Analysis, defect)

defect
Not set

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: andi, Assigned: andi)

References

Details

Attachments

(1 file)

Using the checkers provided by clang-tidy we can refresh the code to make it use the features of C++11 like:

- auto variables declarations
- default CTORS and DTORS
- using new range loop operators
Attachment #8815182 - Flags: review?(mstange)
Assignee: nobody → bpostelnicu
Really, clang-tidy suggests this? I'm not convinced it improves readability nor maintainability.

How has this type of fix gone over in the other bugs that you've filed?
Comment on attachment 8815182 [details]
Bug 1320874 - Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in view/.

https://reviewboard.mozilla.org/r/96210/#review96630

Looks like froydnj r+ed a similar fix in bug 1319752, so if he's fine with it, I'm fine with it. In any case it's not important enough to fight about.
Attachment #8815182 - Flags: review?(mstange) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/176260cf74af
Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in view/. r=mstange
https://hg.mozilla.org/mozilla-central/rev/176260cf74af
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.