Closed Bug 1320880 Opened 4 years ago Closed 4 years ago
Time Picker] Add RTL support to date picker
Date picker's layout should display properly under RTL locales.
I wrote a patch that will expose an API to get directionality from mozIntl: bug 1312053. Simple API so should land soon hopefully.
That's great! I was wondering how to get locale direction so this would definitely help.
Component: XUL Widgets → Layout: Form Controls
Product: Toolkit → Core
Version: unspecified → 53 Branch
Comment on attachment 8838467 [details] Bug 1320880 - Add RTL support to date picker https://reviewboard.mozilla.org/r/113404/#review118350 Looks okay to me! (I didn't test this though). Thanks scottwu!
Attachment #8838467 - Flags: review?(mconley) → review+
The layout looks fine to me when I tested with `ar` and `fa-IR`, though I hope to get more feedback from people who actually uses RTL locales once this lands. Thank you Mike!
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s d5ff982063e2 -d 3436c6cf4123: rebasing 379410:d5ff982063e2 "Bug 1320880 - Add RTL support to date picker r=mconley" (tip) merging toolkit/content/widgets/datetimepopup.xml warning: conflicts while merging toolkit/content/widgets/datetimepopup.xml! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/ee721adb0e10 Add RTL support to date picker r=mconley
You need to log in before you can comment on or make changes to this bug.