Closed Bug 1320880 Opened 7 years ago Closed 7 years ago

[DateTimePicker] Add RTL support to date picker

Categories

(Core :: Layout: Form Controls, defect)

Product:
Core
Component:
Layout: Form Controls
Version:
53 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: scottwu, Assigned: scottwu)

References

(Blocks 1 open bug)

Details

(Keywords: rtl)

Attachments

(1 file)

Bug 1320880 - Add RTL support to date picker
59 bytes, text/x-review-board-request
mconley
: review+
Details 
Date picker's layout should display properly under RTL locales.
I wrote a patch that will expose an API to get directionality from mozIntl: bug 1312053.

Simple API so should land soon hopefully.
That's great! I was wondering how to get locale direction so this would definitely help.
Keywords: rtl
Component: XUL Widgets → Layout: Form Controls
Product: Toolkit → Core
Version: unspecified → 53 Branch
Assignee: nobody → scwwu
Attachment #8838467 - Flags: review?(mconley)
Comment on attachment 8838467 [details]
Bug 1320880 - Add RTL support to date picker

https://reviewboard.mozilla.org/r/113404/#review118350

Looks okay to me! (I didn't test this though). Thanks scottwu!
Attachment #8838467 - Flags: review?(mconley) → review+
The layout looks fine to me when I tested with `ar` and `fa-IR`, though I hope to get more feedback from people who actually uses RTL locales once this lands. Thank you Mike!
Keywords: checkin-needed
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s d5ff982063e2 -d 3436c6cf4123: rebasing 379410:d5ff982063e2 "Bug 1320880 - Add RTL support to date picker r=mconley" (tip)
merging toolkit/content/widgets/datetimepopup.xml
warning: conflicts while merging toolkit/content/widgets/datetimepopup.xml! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ee721adb0e10
Add RTL support to date picker r=mconley
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ee721adb0e10
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.