1320880 - [DateTimePicker] Add RTL support to date picker

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Scott Wu [:scottwu]]

Date picker's layout should display properly under RTL locales.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

I wrote a patch that will expose an API to get directionality from mozIntl: bug 1312053.

Simple API so should land soon hopefully.

Comment 2

[Scott Wu [:scottwu]]

That's great! I was wondering how to get locale direction so this would definitely help.

Comment 3

[Scott Wu [:scottwu]]

Attachment: Bug 1320880 - Add RTL support to date picker

Review commit: https://reviewboard.mozilla.org/r/113404/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/113404/

Comment 4

[Scott Wu [:scottwu]]

Comment on attachment 8838467 [details]
Bug 1320880 - Add RTL support to date picker

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/113404/diff/1-2/

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8838467 [details]
Bug 1320880 - Add RTL support to date picker

https://reviewboard.mozilla.org/r/113404/#review118350

Looks okay to me! (I didn't test this though). Thanks scottwu!

Comment 6

[Scott Wu [:scottwu]]

The layout looks fine to me when I tested with `ar` and `fa-IR`, though I hope to get more feedback from people who actually uses RTL locales once this lands. Thank you Mike!

Comment 7

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s d5ff982063e2 -d 3436c6cf4123: rebasing 379410:d5ff982063e2 "Bug 1320880 - Add RTL support to date picker r=mconley" (tip)
merging toolkit/content/widgets/datetimepopup.xml
warning: conflicts while merging toolkit/content/widgets/datetimepopup.xml! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 8

[Scott Wu [:scottwu]]

Comment on attachment 8838467 [details]
Bug 1320880 - Add RTL support to date picker

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/113404/diff/2-3/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee721adb0e10
Add RTL support to date picker r=mconley

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ee721adb0e10