[DateTimePicker] Add RTL support to date picker

RESOLVED FIXED in Firefox 55

Status

()

Core
Layout: Form Controls
RESOLVED FIXED
6 months ago
3 months ago

People

(Reporter: scottwu, Assigned: scottwu)

Tracking

(Blocks: 1 bug, {rtl})

53 Branch
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
Date picker's layout should display properly under RTL locales.
I wrote a patch that will expose an API to get directionality from mozIntl: bug 1312053.

Simple API so should land soon hopefully.
(Assignee)

Comment 2

6 months ago
That's great! I was wondering how to get locale direction so this would definitely help.
Blocks: 1323674
No longer blocks: 1323674

Updated

5 months ago
Keywords: rtl
Component: XUL Widgets → Layout: Form Controls
Product: Toolkit → Core
Version: unspecified → 53 Branch
Comment hidden (mozreview-request)
(Assignee)

Updated

3 months ago
Assignee: nobody → scwwu
Comment hidden (mozreview-request)
(Assignee)

Updated

3 months ago
Attachment #8838467 - Flags: review?(mconley)

Comment 5

3 months ago
mozreview-review
Comment on attachment 8838467 [details]
Bug 1320880 - Add RTL support to date picker

https://reviewboard.mozilla.org/r/113404/#review118350

Looks okay to me! (I didn't test this though). Thanks scottwu!
Attachment #8838467 - Flags: review?(mconley) → review+
(Assignee)

Comment 6

3 months ago
The layout looks fine to me when I tested with `ar` and `fa-IR`, though I hope to get more feedback from people who actually uses RTL locales once this lands. Thank you Mike!
Keywords: checkin-needed

Comment 7

3 months ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s d5ff982063e2 -d 3436c6cf4123: rebasing 379410:d5ff982063e2 "Bug 1320880 - Add RTL support to date picker r=mconley" (tip)
merging toolkit/content/widgets/datetimepopup.xml
warning: conflicts while merging toolkit/content/widgets/datetimepopup.xml! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Keywords: checkin-needed
Comment hidden (mozreview-request)
(Assignee)

Updated

3 months ago
Keywords: checkin-needed

Comment 9

3 months ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ee721adb0e10
Add RTL support to date picker r=mconley
Keywords: checkin-needed

Comment 10

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ee721adb0e10
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.