Status
People
(Reporter: whimboo, Assigned: whimboo)
Tracking
Firefox Tracking Flags
(firefox52 fixed, firefox53 fixed)
Details
MozReview Requests
| Submitter | Diff | Changes | Open Issues | Last Updated |
|---|---|---|---|---|
| Loading... | ||||
| Error loading review requests: | ||||
Attachments
(1 attachment)
In the following changeset a couple of commands have been marked as deprecated which we should remove now: https://hg.mozilla.org/mozilla-central/rev/7f506cdb77b8 Given that the above changes landed for 39.0, and our oldest supported release is 45ESR, none of those commands would be needed anymore. In detail those are: * closeWindow * getAllCookies * getUrl * goUrl * screenShot Andreas, do you agree?
Flags: needinfo?(ato)
|
||
Comment 1•2 years ago
|
||
Yes. We can quite possibly remove the Selenium 2 compat commands too since we have geckodriver as a shim now.
Flags: needinfo?(ato)
|
(Assignee) | |
Updated•2 years ago
|
||
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
|
|
(Assignee) | |
Comment 2•2 years ago
|
||
(In reply to Andreas Tolfsen ‹:ato› from comment #1) > Yes. We can quite possibly remove the Selenium 2 compat commands too since > we have geckodriver as a shim now. How are those compat Selenium 2 commands translated? When I check geckodriver I do not see any entry for eg `getCurrentWindowHandle`. So I would assume we have to update geckodriver first, to translate it to `getWindowHandle`?
Flags: needinfo?(ato)
| Comment hidden (mozreview-request) |
|
|
||
Comment 4•2 years ago
|
||
| mozreview-review | ||
Comment on attachment 8816425 [details] Bug 1320919 - Remove deprecated Marionette and Selenium 2 compatibility commands. https://reviewboard.mozilla.org/r/97186/#review97530 The commit message is slightly inaccurate. The deprecated commands had nothing to do with geckodriver. Please update it and also include the commands marked deprecated for Selenium 2.
Attachment #8816425 -
Flags: review?(ato) → review-
|
|
||
Comment 5•2 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #2) > (In reply to Andreas Tolfsen ‹:ato› from comment #1) > > Yes. We can quite possibly remove the Selenium 2 compat commands too since > > we have geckodriver as a shim now. > > How are those compat Selenium 2 commands translated? When I check > geckodriver I do not see any entry for eg `getCurrentWindowHandle`. So I > would assume we have to update geckodriver first, to translate it to > `getWindowHandle`? They were used when the Selenium client bindings spoke directly to Marionette over TCP. They are all talking to geckodriver now.
Flags: needinfo?(ato)
| Comment hidden (mozreview-request) |
|
|
||
Comment 7•2 years ago
|
||
| mozreview-review | ||
Comment on attachment 8816425 [details] Bug 1320919 - Remove deprecated Marionette and Selenium 2 compatibility commands. https://reviewboard.mozilla.org/r/97186/#review97544
Attachment #8816425 -
Flags: review?(ato) → review+
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/36a7105524b6 Remove deprecated Marionette and Selenium 2 compatibility commands. r=ato
|
||
Comment 9•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/36a7105524b6
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
|
(Assignee) | |
Comment 10•2 years ago
|
||
Test-only change which would be good to have in the next ESR release. Please uplift to aurora. Thanks.
status-firefox52: --- → affected
Whiteboard: [checkin-needed-aurora]
|
||
Comment 11•2 years ago
|
||
| bugherderuplift | ||
https://hg.mozilla.org/releases/mozilla-aurora/rev/3343d88f45c3
status-firefox52: affected → fixed
Whiteboard: [checkin-needed-aurora]
You need to log in
before you can comment on or make changes to this bug.
Description
•