1320919 - Remove old and deprecated Geckodriver commands

Status: RESOLVED FIXED

(Testing :: Marionette, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1] (away 02/13 - 02/19)]

In the following changeset a couple of commands have been marked as deprecated which we should remove now:

https://hg.mozilla.org/mozilla-central/rev/7f506cdb77b8

Given that the above changes landed for 39.0, and our oldest supported release is 45ESR, none of those commands would be needed anymore.

In detail those are:
* closeWindow
* getAllCookies
* getUrl
* goUrl
* screenShot

Andreas, do you agree?

Comment 1

[Andreas Tolfsen ❲:ato❳]

Yes.  We can quite possibly remove the Selenium 2 compat commands too since we have geckodriver as a shim now.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1] (away 02/13 - 02/19)]

(In reply to Andreas Tolfsen ‹:ato› from comment #1)
> Yes.  We can quite possibly remove the Selenium 2 compat commands too since
> we have geckodriver as a shim now.

How are those compat Selenium 2 commands translated? When I check geckodriver I do not see any entry for eg `getCurrentWindowHandle`. So I would assume we have to update geckodriver first, to translate it to `getWindowHandle`?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1] (away 02/13 - 02/19)]

Attachment: Bug 1320919 - Remove deprecated Marionette and Selenium 2 compatibility commands.

Review commit: https://reviewboard.mozilla.org/r/97186/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97186/

Comment 4

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8816425 [details]
Bug 1320919 - Remove deprecated Marionette and Selenium 2 compatibility commands.

https://reviewboard.mozilla.org/r/97186/#review97530

The commit message is slightly inaccurate.  The deprecated commands had nothing to do with geckodriver.  Please update it and also include the commands marked deprecated for Selenium 2.

Comment 5

[Andreas Tolfsen ❲:ato❳]

(In reply to Henrik Skupin (:whimboo) from comment #2)
> (In reply to Andreas Tolfsen ‹:ato› from comment #1)
> > Yes.  We can quite possibly remove the Selenium 2 compat commands too since
> > we have geckodriver as a shim now.
> 
> How are those compat Selenium 2 commands translated? When I check
> geckodriver I do not see any entry for eg `getCurrentWindowHandle`. So I
> would assume we have to update geckodriver first, to translate it to
> `getWindowHandle`?

They were used when the Selenium client bindings spoke directly to Marionette over TCP.  They are all talking to geckodriver now.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1] (away 02/13 - 02/19)]

Comment on attachment 8816425 [details]
Bug 1320919 - Remove deprecated Marionette and Selenium 2 compatibility commands.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/97186/diff/1-2/

Comment 7

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8816425 [details]
Bug 1320919 - Remove deprecated Marionette and Selenium 2 compatibility commands.

https://reviewboard.mozilla.org/r/97186/#review97544

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36a7105524b6
Remove deprecated Marionette and Selenium 2 compatibility commands. r=ato

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/36a7105524b6

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1] (away 02/13 - 02/19)]

Test-only change which would be good to have in the next ESR release. Please uplift to aurora. Thanks.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3343d88f45c3