1320957 - Devtool's Close button should expand to rightmost corner so it's easier to click

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P2)

Description

[Jens]

Attachment: Close_button_NOT_expanding_to_rightmost_border.png

STR:
1. Move or "slide" your mouse to the outmost right towards the close button. 

AR:
2. Click, click, click. Not closing. Why? Hell. Click, click, click. 
3. "Target" a bit better on the close button. Click. And it closes.

ER:
Usually window close buttons expand to the top/right edges to make closing easy. Even if the close button is visually not expanding to the right/top most edges, its "event" area does. E.g. under Windows or Ubuntu Unity you can just move the mouse sloppily to the right/top most corner, and it will close.

See the screenshots. The element picker button does this good, the devtool's close button not. The Close button's clickable area should stretch until the rightmost area.

Comment 1

[Jens]

Attachment: Pick_button_DOES_expanding_to_leftmost_border_GOOD.png

Comment 2

[Brian Grinstead [:bgrins]]

Good catch, we should fix this.  Helen, think we should make any visual / spacing changes as well, or just make it so the hit target for the close button extends all the way to the right?

Comment 3

[Jens]

This is fixed in FF54, presumably as a side effect of fixing Bug 1255116.