1320963 - Static assets are no longer being served with a large max-age

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Ed Morley [:emorley]]

Presuming this is a regression from bug 1315933, that needs a corresponding `IMMUTABLE_FILE_RE` update in whitenoise_custom.py

$ curl -I https://treeherder.mozilla.org/js/index.min.8020f791cf509372.js
HTTP/1.1 200 OK
Connection: keep-alive
Server: gunicorn/19.6.0
Date: Tue, 29 Nov 2016 14:40:00 GMT
Last-Modified: Fri, 25 Nov 2016 18:55:06 GMT
X-Content-Type-Options: nosniff
X-Frame-Options: DENY
Content-Length: 1010711
Cache-Control: public, max-age=60
Access-Control-Allow-Origin: *
Strict-Transport-Security: max-age=31536000; includeSubDomains
X-Xss-Protection: 1; mode=block
Vary: Accept-Encoding
Content-Type: application/javascript; charset="utf-8"
Via: 1.1 vegur

Comment 1

[Ed Morley [:emorley]]

Spotted via:
https://www.webpagetest.org/result/161129_BX_V82/

Comment 2

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:fix-static-asset-max-age > mozilla:master

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/2b9cf0d7fc6ae395cc7451fd3601a27082a6379a
Bug 1320963 - Fix regex used to determine long max-age static assets

The UI build switched from grunt-cache-busting to grunt-cache-bust in
bug 1315933, however the regex for the hashed filenames was not updated.

Comment 4

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:really-fix-static-asset-max-age > mozilla:master

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/2fc96242c59b18a267dfb902012443761fde4961
Bug 1320963 - Really fix regex for long max-age static assets

The previous change adjusted the hash length, however the filenames also
no longer use a hyphen as a separator, eg:
index.min.fe5b2cd9a306c9d1.css

Comment 6

[Ed Morley [:emorley]]

$ curl -Is https://treeherder.allizom.org/js/index.min.a57978367554c8ee.js | grep immutable
Cache-Control: max-age=315360000, public, immutable

\o/