132098 - IMAP: Can't Undo/Redo delete message for 'remove it immediately' model

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[Simon Fraser [no longer active]]

Trying to undo the deletion of a mail message almost always fails for me. I'm
deleting using the Delete key in the thread pane of the 3-pane window. IMAP. My
IMAP delete model is 'Delete immediately'. The Undo menu item is enabled,
suggesting that Undo should work, but it never does.

This is a serious dataloss bug for me.

Comment 1

[David :Bienvenu]

this works fine for me on Windows, in the brief testing I just did. Undo, redo,
etc., in inbox and other folders. It might be mac-specific, or recreating it
could be more involved.

Comment 2

[Michael Buckland]

Discussed at Mail News bug meeting with Engineering, QA Mktng and PjM.  Decided
to plus this bug.

Comment 3

[(not reading, please use [e-mail] instead)]

jfd, as our mac expert, can you investigate?

Comment 4

[Navin Gupta]

I am seeing the same behavior on windows and mac (latest builds) and that is we
have to switch to another folder and come back to see the header. 

taking.

Comment 5

[Jean-Francois Ducarroz]

Yes I'll...

Comment 6

[Navin Gupta]

jf, this is not a mac specific problem, and I am seeing what the problem is. 
taking again. 

This is not a dataloss because header is seen on switching folders, so undo is
working, but header is not downloaded so it is not seen immediately.  

Comment 7

[Navin Gupta]

The fix for Undo is to download the header for 'remove it immediately' model. 
For Redo to work, we need to delete the header from db for this model, so
changed it from DeleteIsMoveToTrash to !ShowDeletedMsgs().

Comment 8

[Navin Gupta]

Attachment: proposed fix

Comment 9

[David :Bienvenu]

Comment on attachment 76239 [details] [diff] [review]
proposed fix

r=bienvenu, this looks like the right fix to me. For regression testing, we
should make sure that doing a shift delete and undoing it works in all the
delete models.

Comment 10

[Navin Gupta]

shift delete and undo shift delete works for all three models. 

Comment 11

[Scott MacGregor]

Comment on attachment 76239 [details] [diff] [review]
proposed fix

sr=mscott

Comment 12

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 76239 [details] [diff] [review]
proposed fix

a=dbaron for trunk checkin

Comment 13

[Michael Buckland]

Discussed in Mail News bug meeting.  Decided to ADT1 this bug.

Comment 14

[Jaime Rodriguez, Jr.]

ADT2 per ADT triage.

Comment 15

[Navin Gupta]

fixed

Comment 16

[Karen Huang]

Verified on Windows 05-12-20-pr1
Linux 05-12-23-pr1
Mac 05-12-17-pr1