Closed Bug 1321051 Opened 3 years ago Closed 3 years ago

Firefox 52 should not offer undecodable video resolutions on YouTube when e10s is enabled on Windows

Categories

(Core :: Audio/Video: Playback, defect)

52 Branch
x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: xjbciq56, Assigned: gerald)

References

()

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20161128004004

Steps to reproduce:

- launch firefox-52.0a2.de.win32 or firefox-52.0a2.de.win64
- create a new profile and use this one.
- disable e10s, either in about:config or in the settings



Actual results:

youtube now offers me only resolutions up to 1080p

MP4 that is, Webm is not enabled by default. if we enable Webm, all resolutions are available with disabled e10s


Expected results:

we want all available MP4 resolutions, like we have with enabled e10s

the same issue i see with nightly firefox-53.0a1.de.winxx

reproducible on my 3 windows 7 systems, anytime.
OS: Unspecified → Windows 7
Hardware: Unspecified → x86_64
Component: Untriaged → Audio/Video: Playback
Product: Firefox → Core
Windows 7 doesn't support > 1080 per Microsoft specification.
https://msdn.microsoft.com/en-us/library/windows/desktop/dd797815(v=vs.85).aspx
"Note  In Windows 7, the maximum supported resolution is 1920 × 1088 pixels for both software and DXVA decoding."


It shouldn't be offered with e10s enabled either.

:gerald, is there something wrogn with the test?

(after which this bug can be closed as invalid/or wontfix)
Flags: needinfo?(gsquelart)
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a835589ae0c63a2d91be150d80b5fc600e44b447&tochange=7a7ba250bb2f5a7cc7acf4b97145425c5292e894

Gerald Squelart — Bug 1176218 - p13. Reject Resolutions that are too big for Windows' decoder - r=jya
Blocks: 1176218
Summary: windows firefox >v51 does not offer youtube MP4 videos >1080p when e10s is disabled → Firefox 52 should not offer video resolutions > 1080p on YouTube when e10s is disabled on Windows 7 (and lower)
Summary: Firefox 52 should not offer video resolutions > 1080p on YouTube when e10s is disabled on Windows 7 (and lower) → Firefox 52 should not offer video resolutions > 1080p on YouTube when e10s is enabled on Windows 7 (and lower)
In fact, this issue can be found on Windows>7 as well, e.g.: on Windows 10 with an 8K video, non-e10s correctly offers 2180p max, but e10s offers 4320p, which is bigger than the maximum allowed 4096×2304.

It seems that in e10s mode, something goes wrong inside WMFDecoderModule::Supports() and it doesn't check the requested image size.
I'll investigate...
Assignee: nobody → gsquelart
Flags: needinfo?(gsquelart)
Summary: Firefox 52 should not offer video resolutions > 1080p on YouTube when e10s is enabled on Windows 7 (and lower) → Firefox 52 should not offer undecodable video resolutions on YouTube when e10s is enabled on Windows
now that's some really bad news. on none of my 3 win 7 systems i had problems playing 4k videos.

why not make the high resolutions available through about:config for the more experienced users? so he can check and decide if it works?

or why not optionally use ffmpeg for video decoding? as far as i can see, this is the case in the linux version.

i was hoping for a beautifully working (well, for my needs) firefox v52 ESR, but now it seems i have to stick to firefox v51 for a long, long time. :(
What about enabling webm?

We could make the restriction (a Microsoft one I might add), behind a pref.
BTW, chrome has the same restriction. H264 decoding via Windows media foundation(used for hardware decoding) is disabled on win 7 if the resolution is greater than 1088 and fall back on ffmpeg software decoder. That's an option we can't offer however. 

If your machine is fast enough for decoding h264 in software, then it's typically fast enough to decode VP9 which is a superior codec.
>> We could make the restriction (a Microsoft one I might add), behind a pref.
:) that sounds good to me.
and yes, i know it is a microsoft restriction, well, it only says it is not *officially* supported.
but as mentioned, even on my old notebook with core i5 mobile (only 2 cores) and intel HD 4000 graphics it just works fine, also on another notebook with AMD 8A. so i guess it works for most people.
i might start a poll in some forum.

webm isn't really a good alternative (unfortunately), the CPU usage is way higher, the CPU fan goes wild... and loud!
i know there have been done some improvements in that regard lately, and i can feel them, but still MP4 (with hardware supported decoding) does the job lot better.
testing above link by Loic @2560p (firefox 51), output on my external 4k display, i have usually between 40% and 50% CPU usage using webm, and below 10% when playing MP4

ok, lots of text, thanks for reading.
ok, i see there is a new about:config value

media.wmf.allow-unsupported-resolutions;true

that seems to help here, sadly starting not before firefox 53 obviously. :(
i was hoping it could make it into firefox 52 ESR.
Comment on attachment 8832310 [details]
Bug 1321051 - Override Supports(TrackInfo) in RemoteDecoderModule -

https://reviewboard.mozilla.org/r/108650/#review109826
Attachment #8832310 - Flags: review?(jyavenard) → review+
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9635a6d92b1c
Override Supports(TrackInfo) in RemoteDecoderModule - r=jya
https://hg.mozilla.org/mozilla-central/rev/9635a6d92b1c
Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.