1321052 - Convert ProcessHangMonitor to use endpoints

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1321052 - Convert ProcessHangMonitor to use endpoints.

Review commit: https://reviewboard.mozilla.org/r/102768/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/102768/

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8824252 [details]
Bug 1321052 - Convert ProcessHangMonitor to use endpoints.

https://reviewboard.mozilla.org/r/102768/#review104316

::: dom/ipc/ProcessHangMonitorIPC.h:24
(Diff revision 1)
>  namespace dom {
>  class ContentParent;
>  } // namespace dom
>  
>  PProcessHangMonitorParent*
> -CreateHangMonitorParent(mozilla::dom::ContentParent* aContentParent,
> +CreateHangMonitorParent(dom::ContentParent* aContentParent,

This no longer needs to be exposed in the header file.

Comment 3

[Andrew McCreight [:mccr8]]

(In reply to Bill McCloskey (:billm) from comment #2)
> This no longer needs to be exposed in the header file.

Good catch. Thanks for the review.

Comment 4

[Andrew McCreight [:mccr8]]

Comment on attachment 8824252 [details]
Bug 1321052 - Convert ProcessHangMonitor to use endpoints.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/102768/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6555c8f64155
Convert ProcessHangMonitor to use endpoints. r=billm

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6555c8f64155