132106 - Put code into PEmbed for using XUL prefs dialog

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: Mac, defect)

Description

[Conrad Carlen (not reading bugmail)]

For demo purposes and to test embedding jar packaging, we need the ability to
use the XUL prefs dialog in PPEmbed. This was split off from bug 128924. This
bug contains just the code and resource changes to PPEmbed.

Comment 1

[Conrad Carlen (not reading bugmail)]

Attachment: patch

Comment 2

[Conrad Carlen (not reading bugmail)]

Pink, Beard - can you r=/sr=?

Comment 3

[Conrad Carlen (not reading bugmail)]

Changing component, now that we have one :-)

Comment 4

[Patrick C. Beard]

Comment on attachment 75027 [details] [diff] [review]
patch

I like it. r=beard

Comment 5

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 75027 [details] [diff] [review]
patch

+		case PP_PowerPlant::cmd_About:
+			outEnabled = false;
+      break;
+      

did you mean to turn off the about menu item?

r=pink

Comment 6

[Conrad Carlen (not reading bugmail)]

> did you mean to turn off the about menu item?
Yes. I don't have time to make an about box for it (and would feel pretty silly
asking for a= on that). But, right now, with it enabled, it brings up the wrong
dialog which causes the app to hang. Disabling it at least avoids this.

Patrick - you're a super-reviewer now, right? If so, can I take your r= as an sr=?

Comment 7

[Patrick C. Beard]

Comment on attachment 75027 [details] [diff] [review]
patch

sr=beard

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 75027 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 9

[Conrad Carlen (not reading bugmail)]

Checked in.

Comment 10

[Michael Dunn]

Clean up verification of dated code change bus