1321140 - We don't need to clamp up the SeekTarget AGAIN in the SeekTask.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Tzuhao Kuo [:kaku]]

It should already be done in the HTMLMediaElement::seek().
http://searchfox.org/mozilla-central/rev/d98418da69edeb1f2f8e6f3840157fae1512f89b/dom/html/HTMLMediaElement.cpp#1992-2053

Comment 1

[Tzuhao Kuo [:kaku]]

Put an assertion to try:
https://hg.mozilla.org/try/rev/c9d50b5ed3ae48cf3e30967367ac4f82f2872c3c

Try result is good:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=12dd5935d6f84c30647d1cab6f69745451bcb684
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a7cbd1582f2d236e8191742791254480bf74ecb7

Comment 2

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1321140 - don't clamp up the SeekTarget again in the AccurateSeekTask's constructor;

Review commit: https://reviewboard.mozilla.org/r/96432/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/96432/

Comment 3

[Tzuhao Kuo [:kaku]]

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c568ffadbaa03cd5dfcfd24a291c259bfa027ce4
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d903e8671fdb7cde12bd4190cce55bafaac820ce

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8815551 [details]
Bug 1321140 - don't clamp up the SeekTarget again in the AccurateSeekTask's constructor;

https://reviewboard.mozilla.org/r/96432/#review96664

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8f7f94968f7b
don't clamp up the SeekTarget again in the AccurateSeekTask's constructor; r=jwwang

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8f7f94968f7b