Closed
Bug 1321217
Opened 8 years ago
Closed 8 years ago
Remove legacy generator from docshell/.
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
|
38.82 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Just replaced legacy generator with ES6 generator.
some notes:
* docshell/test/browser/browser_bug349769.js
|checkContentProcess| wasn't called properly.
added |newBrowser| parameter, and also just returned ContentTask.spawn result.
* docshell/test/chrome/bug112564_window.xul and some tests
ES6 generator doesn't throw StopIteration.
also, we can just finish the test within testsIterator, instead of checking return value.
* docshell/test/test_bug475636.html
ES6 generator doesn't have |send|, but |next| receives a value
Attachment #8815632 -
Flags: review?(bugs)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8815632 [details] [diff] [review]
Remove legacy generator from docshell/.
rs+
Make sure we run as many test assertions with and without this patch.
Attachment #8815632 -
Flags: review?(bugs) → review+
|
Assignee | |
Comment 2•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/43472882f637c01e43e3ecbfd37c1ffff7fabfa1
Bug 1321217 - Remove legacy generator from docshell/. r=smaug
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•