Created attachment 8815632 [details] [diff] [review] Remove legacy generator from docshell/. Just replaced legacy generator with ES6 generator. some notes: * docshell/test/browser/browser_bug349769.js |checkContentProcess| wasn't called properly. added |newBrowser| parameter, and also just returned ContentTask.spawn result. * docshell/test/chrome/bug112564_window.xul and some tests ES6 generator doesn't throw StopIteration. also, we can just finish the test within testsIterator, instead of checking return value. * docshell/test/test_bug475636.html ES6 generator doesn't have |send|, but |next| receives a value
Attachment #8815632 - Flags: review?(bugs)
Comment on attachment 8815632 [details] [diff] [review] Remove legacy generator from docshell/. rs+ Make sure we run as many test assertions with and without this patch.
Attachment #8815632 - Flags: review?(bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/43472882f637c01e43e3ecbfd37c1ffff7fabfa1 Bug 1321217 - Remove legacy generator from docshell/. r=smaug
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.