Closed Bug 1321228 Opened 3 years ago Closed 3 years ago

Remove legacy generator from testing/.

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox-esr52 --- fixed
firefox53 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

Just replaced legacy generator with ES6 generator.
Attachment #8815643 - Flags: review?(dburns)
Attachment #8815643 - Flags: review?(dburns) → review?(ato)
Comment on attachment 8815643 [details] [diff] [review]
Remove legacy generator from testing/.

Review of attachment 8815643 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this looks good!  We actually have a similar patch for the generator functions under testing/marionette in progress, but this isn’t an issue.

The patch is missing the bug number in the commit message, and the testing/mochitest changes should be in a separate commit.  Once you have fixed these things, please feel free to land.
Attachment #8815643 - Flags: review?(ato) → review+
https://hg.mozilla.org/mozilla-central/rev/87b153f88024
https://hg.mozilla.org/mozilla-central/rev/da42dfa01416
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Tooru, would there be any issues with uplifting this patches to esr52? I'm asking because I have a dozen of commits across bugs to uplift and this is causing merge conflicts. Having it uplifted would help me a lot.
Flags: needinfo?(arai.unmht)
Maybe also asking Joel given that he has the overview of the tests.
Flags: needinfo?(jmaher)
I don't see any problem with this being uplifted, it seems like if it does cause problems we could easily fix those as well.
Flags: needinfo?(jmaher)
Thank you Joel. So lets try to get this test-only patch uplifted.
Flags: needinfo?(arai.unmht)
Whiteboard: [checkin-needed-esr52]
You need to log in before you can comment on or make changes to this bug.