1321255 - Don't use right/left references in string identifiers (sourceTabs.closeTabsToRight)

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Francesco Lodolo [:flod]]

Issue pointed out by a couple of our localizers.

https://dxr.mozilla.org/mozilla-central/rev/a69583d2dbc6fdc18f63761a89cf539c356668be/devtools/client/locales/en-US/debugger.properties#216

# LOCALIZATION NOTE (sourceTabs.closeTabsToRight): Editor source tab context menu item
# for closing the tabs to the right of the selected tab.
sourceTabs.closeTabsToRight=Close tabs to the right

That won't be to true for RTL languages.

The right approach is the one used in browser.dtd
https://dxr.mozilla.org/mozilla-central/rev/a69583d2dbc6fdc18f63761a89cf539c356668be/browser/locales/en-US/chrome/browser/browser.dtd#29

<!-- LOCALIZATION NOTE (closeTabsToTheEnd.label): This should indicate the
direction in which tabs are closed, i.e. locales that use RTL mode should say
left instead of right. -->
<!ENTITY  closeTabsToTheEnd.label            "Close Tabs to the Right">
<!ENTITY  closeTabsToTheEnd.accesskey        "i">

No reference to direction in string ID, clear localization note.

Comment 1

[Bryan Clark (DevTools PM) [:clarkbw]]

Tracking this in GitHub now https://github.com/devtools-html/debugger.html/issues/1751

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

This has been fixed in GitHub but it looks like the fix hasn't landed in m-c yet.
https://dxr.mozilla.org/mozilla-central/source/devtools/client/locales/en-US/debugger.properties#278