Closed Bug 1321270 Opened 4 years ago Closed 4 years ago
Get rid of ns
IWindow Creator2::PARENT _IS _LOADING _OR _RUNNING _TIMEOUT
No description provided.
Attachment #8815696 - Flags: review?(bugs)
Comment on attachment 8815696 [details] [diff] [review] parentTimeoutLoading.patch Really old stuff from bug 160212. >@@ -976,36 +970,18 @@ nsWindowWatcher::OpenWindowInternal(mozI > is in a situation that's likely to mean this is an unrequested > popup window we're creating. However we're not completely honest: > we clear that indicator if the opener is chrome, so that the > downstream consumer can treat the indicator to mean simply > that the new window is subject to popup control. */ > nsCOMPtr<nsIWindowCreator2> windowCreator2( > do_QueryInterface(mWindowCreator)); Remove the comment above. Looks like this code could use some more cleanups, and we could remove the whole nsIWindowCreator2, but not in this bug.
Attachment #8815696 - Flags: review?(bugs) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/7c0ca61c3552 Get rid of nsIWindowCreator2::PARENT_IS_LOADING_OR_RUNNING_TIMEOUT, r=smaug
backout -> bustage https://treeherder.mozilla.org/logviewer.html#?job_id=40117375&repo=mozilla-inbound
Backout by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c8c4aa44419c Backed out changeset 7c0ca61c3552 for bustage
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/d4b9373141c6 Get rid of nsIWindowCreator2::PARENT_IS_LOADING_OR_RUNNING_TIMEOUT, r=smaug
Nice, this patch just made my life a little bit easier. Thank you! :-)
You need to log in before you can comment on or make changes to this bug.