Closed Bug 1321270 Opened 3 years ago Closed 3 years ago

Get rid of nsIWindowCreator2::PARENT_IS_LOADING_OR_RUNNING_TIMEOUT

Categories

(Core :: DOM: Core & HTML, defect)

50 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(1 file)

No description provided.
Attachment #8815696 - Flags: review?(bugs)
Comment on attachment 8815696 [details] [diff] [review]
parentTimeoutLoading.patch

Really old stuff from bug 160212.

>@@ -976,36 +970,18 @@ nsWindowWatcher::OpenWindowInternal(mozI
>          is in a situation that's likely to mean this is an unrequested
>          popup window we're creating. However we're not completely honest:
>          we clear that indicator if the opener is chrome, so that the
>          downstream consumer can treat the indicator to mean simply
>          that the new window is subject to popup control. */
>       nsCOMPtr<nsIWindowCreator2> windowCreator2(
>         do_QueryInterface(mWindowCreator));
Remove the comment above.

Looks like this code could use some more cleanups, and we could remove the whole nsIWindowCreator2, but not in this bug.
Attachment #8815696 - Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c0ca61c3552
Get rid of nsIWindowCreator2::PARENT_IS_LOADING_OR_RUNNING_TIMEOUT, r=smaug
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8c4aa44419c
Backed out changeset 7c0ca61c3552 for bustage
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d4b9373141c6
Get rid of nsIWindowCreator2::PARENT_IS_LOADING_OR_RUNNING_TIMEOUT, r=smaug
https://hg.mozilla.org/mozilla-central/rev/d4b9373141c6
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Nice, this patch just made my life a little bit easier.  Thank you!  :-)
Flags: needinfo?(amarchesini)
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.