Closed Bug 1321277 Opened 3 years ago Closed 3 years ago

Refactor forground arena finalisation

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

Here's a patch to refactor arena finalization a little.  It removes an unused overload of ArenaLists::finalizeNow, merges finalizeNow and forceFinalizeNow, and removes the keepArenas argument which is now always KEEP_ARENAS.
Attachment #8815699 - Flags: review?(sphink)
Attachment #8815699 - Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c899c1c54f1e
Refactor arena sweeping for simplicity r=sfink
https://hg.mozilla.org/integration/mozilla-inbound/rev/c58717d82c4b
Remove use of AutoKeepAtoms from last ditch GC r=sfink
The second patch is from bug 1321268, right?
(In reply to Guilherme Lima from comment #2)
> The second patch is from bug 1321268, right?

Yes, sorry I pushed that second patch with the wrong bug number in the commit message.
https://hg.mozilla.org/mozilla-central/rev/c899c1c54f1e
https://hg.mozilla.org/mozilla-central/rev/c58717d82c4b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.