1321283 - WARNING: Don't know the best CFLAGS for this system

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[GetA_GetB]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.99 Safari/537.36

Steps to reproduce:

1. start-shell-msvc2015-x64.bat
2. Download https://archive.mozilla.org/pub/firefox/releases/50.0.1/source/ File    firefox-50.0.1.source.tar.xz    186M    28-Nov-2016 17:30
3. Unpack  firefox-50.0.1.source.tar.xz
4. cd c:/
5. cd firefox-50.0.1
6. touch .mozconfig
7. Edit .mozconfig and add
# For x64
ac_add_options --target=x86_64-pc-mingw32
ac_add_options --host=x86_64-pc-mingw32

ac_add_options --enable-optimize="-O2"

8. ./mach build

bla-bla-bla...

********************************************************
2:14.33 js\src\ctypes\libffi> * WARNING: Don't know the best CFLAGS for this system  *
2:14.33 js\src\ctypes\libffi> * Use ./configure CFLAGS=... to specify your own flags *
2:14.33 js\src\ctypes\libffi> * (otherwise, a default of CFLAGS=-O3 will be used)    *
2:14.33 js\src\ctypes\libffi> ********************************************************


Actual results:

The successful compilation and activate the browser.


What flags or totally accepted.
How to be?



Expected results:

I must have been setted flags that I point out in
ac_add_options --enable-optimize = "- O2"

Comment 1

[Mike Hommey [:glandium]]

As hinted by the message, this is only a warning. It is also obsoleted by bug 1262155 in Firefox 51.

Comment 2

[GetA_GetB]

Ok, i have new problem.

Build progress...

4:16.72 memory\jemalloc\src> CONFIG             : --build=x86_64-pc-mingw32 --host=x86_64-pc-mingw32 --enable-stats --with-jemalloc-prefix=je_ --disable-valgrind ac_cv_func_memalign=yes ac_cv_func_valloc=yes --with-mangling=malloc_usable_size:replace_malloc_usable_size,valloc:replace_valloc,memalign:replace_memalign,free:replace_free,realloc:replace_realloc,calloc:replace_calloc,aligned_alloc:replace_aligned_alloc,posix_memalign:replace_posix_memalign,malloc:replace_malloc --disable-tls AS=ml64.exe CC=cl.EXE CXX=cl.EXE 'CPP=cl.EXE -E' AR=lib 'RANLIB=echo not_ranlib' 'STRIP=echo not_strip' CPPFLAGS= 'EXTRA_CFLAGS=-TC -nologo -wd4091 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -utf-8 -FS -Gw -wd4244 -wd4267 -we4553' 'LDFLAGS=-LARGEADDRESSAWARE -NXCOMPAT -DYNAMICBASE' CFLAGS= ac_cv_func_sbrk=false --enable-munmap --disable-cache-oblivious --cache-file=c:/mozilla-source/mozilla-central/obj-x86_64-pc-mingw32/memory/jemalloc/src/config.cache build_alias=x86_64-pc-mingw32 host_alias=x86_64-pc-mingw32
 4:16.72 memory\jemalloc\src> CC                 : cl.EXE -nologo
 4:16.72 memory\jemalloc\src> CFLAGS             : -Zi -MT -W3 -FS -O2
 4:16.72 memory\jemalloc\src> EXTRA_CFLAGS       : -TC -nologo -wd4091 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -utf-8 -FS -Gw -wd4244 -wd4267 -we4553

 4:16.72 memory\jemalloc\src> CFLAGS             : -Zi -MT -W3 -FS -O2

-O2 ???

.mozconfig:

ac_add_options --target=x86_64-pc-mingw32
ac_add_options --host=x86_64-pc-mingw32

ac_add_options --enable-optimize="-O3"

Comment 3

[Mike Hommey [:glandium]]

We don't use the flags memory/jemalloc/src/configure sets.