Only enable PageProtectingVector and associated machinery on Nightly and DevEdition

RESOLVED FIXED in Firefox 52

Status

()

Core
JavaScript Engine
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: ehoogeveen, Assigned: ehoogeveen)

Tracking

Trunk
mozilla53
Points:
---

Firefox Tracking Flags

(firefox52 fixed, firefox53 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

a year ago
PageProtectingVector causes some unfortunate slowdown, especially for WASM. I have some other ideas to address that, but let's limit its exposure first.
(Assignee)

Comment 1

a year ago
Created attachment 8815703 [details] [diff] [review]
Disable protection on Beta and Release builds.

Pretty simple. Aurora52 will need a small rebase since it doesn't have the ASAN fix yet.
Attachment #8815703 - Flags: review?(jdemooij)
(Assignee)

Comment 2

a year ago
I should note that this technically doesn't remove PageProtectingVector from the equation entirely, but it eliminates most of the work it does.
Comment on attachment 8815703 [details] [diff] [review]
Disable protection on Beta and Release builds.

Review of attachment 8815703 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8815703 - Flags: review?(jdemooij) → review+
(Assignee)

Updated

a year ago
Status: NEW → ASSIGNED
Keywords: checkin-needed

Comment 4

a year ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e333afeac179
Disable protection on Beta and Release builds. r=jandem
Keywords: checkin-needed

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e333afeac179
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
(Assignee)

Comment 6

a year ago
Created attachment 8817477 [details] [diff] [review]
Disable PageProtectingVector completely in mozilla52.

Let's just disable it completely on 52. This also fixes the misuses of capacity() I noticed, just so PageProtectingVector is bug free for the ESR (should someone, e.g. an embedder decide to use it).
Attachment #8817477 - Flags: review?(jdemooij)
(Assignee)

Comment 7

a year ago
Comment on attachment 8817477 [details] [diff] [review]
Disable PageProtectingVector completely in mozilla52.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1305360
[User impact if declined]: PageProtectingVector is causing some performance issues for WASM and we aren't getting any value out of it right now.
[Is this code covered by automated tests?]: Not explicitly, but the JITs exercise it heavily.
[Has the fix been verified in Nightly?]: A fix has landed on m-c, but that fix only disables it on beta and release. This branch fix disables it across the board.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: Low risk.
[Why is the change risky/not risky?]: This just disables existing functionality using a few lines of code. PageProtectingVector is already 'disabled' for small buffers, this uses that same code to prevent ever enabling it.
[String changes made/needed]: None.
Attachment #8817477 - Flags: approval-mozilla-aurora?
Comment on attachment 8817477 [details] [diff] [review]
Disable PageProtectingVector completely in mozilla52.

Review of attachment 8817477 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8817477 - Flags: review?(jdemooij) → review+
Comment on attachment 8817477 [details] [diff] [review]
Disable PageProtectingVector completely in mozilla52.

disable PageProtectingVector in aurora52
Attachment #8817477 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 10

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/4dd95794151f
status-firefox52: affected → fixed
You need to log in before you can comment on or make changes to this bug.