1321297 - Like colors being used for different domains in AS Highlights

Status: VERIFIED FIXED

(Firefox for iOS :: Home screen, defect, P2)

Description

[Maurya Talisetti]

Attachment: Simulator Screen Shot 22-Nov-2016, 4.55.17 PM.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20161104212021

Steps to reproduce:

Hard to exactly reproduce, but I had a decent history on my desktop to start with. Then I synced onto an iPhone.


Actual results:

The AS Panel got populated, but with default favicons (not the domain favicons). Github and Youtube based highlights ended up having like colors for their favicons. See screenshot.


Expected results:

Github and Youtube based highlights should have different colors for their favicons.

Comment 1

[Farhan Patel [:farhan]]

The default background colors are used to provide a better experience browsing history/bookmarks. We still have those background colors but now with the default favicons provided by Tippy-Top-Sites, this no longer is an issue. Sites like Google / Youtube / Github all have default favicons which we'll avoid this issue.

Comment 2

[Simon Basca [:SimonB]]

Verifying as fix on master b3b12590.